All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C
Date: Thu, 18 Sep 2025 19:31:05 +0200	[thread overview]
Message-ID: <10594621.0AQdONaE2F@diego> (raw)
In-Reply-To: <20250901100027.164594-2-amadeus@jmu.edu.cn>

Am Montag, 1. September 2025, 12:00:25 Mitteleuropäische Sommerzeit schrieb Chukun Pan:
> The Radxa E52C SBC do not have HDMI output, so disable
> the display subsystem to avoid the following error log:
> 
> *ERROR* No available vop found for display-subsystem.
> 
> Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>

I'm torn on the approach vs. just removing the error line in the driver.

Returning -ENODEV from rockchip_drm_platform_of_probe() is correct,
but the error log could just be a debug one instead.

Because running a system without active vops is obviously fine.


Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 48ddc43e2ab5..1883bd183396 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -207,6 +207,10 @@ &cpu_l3 {
>  	cpu-supply = <&vdd_cpu_lit_s0>;
>  };
>  
> +&display_subsystem {
> +	status = "disabled";
> +};
> +
>  &i2c0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c0m2_xfer>;
> 






WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Chukun Pan <amadeus@jmu.edu.cn>, FUKAUMI Naoki <naoki@radxa.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C
Date: Thu, 18 Sep 2025 19:31:05 +0200	[thread overview]
Message-ID: <10594621.0AQdONaE2F@diego> (raw)
In-Reply-To: <20250901100027.164594-2-amadeus@jmu.edu.cn>

Am Montag, 1. September 2025, 12:00:25 Mitteleuropäische Sommerzeit schrieb Chukun Pan:
> The Radxa E52C SBC do not have HDMI output, so disable
> the display subsystem to avoid the following error log:
> 
> *ERROR* No available vop found for display-subsystem.
> 
> Fixes: 9be4171219b6 ("arm64: dts: rockchip: Add Radxa E52C")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>

I'm torn on the approach vs. just removing the error line in the driver.

Returning -ENODEV from rockchip_drm_platform_of_probe() is correct,
but the error log could just be a debug one instead.

Because running a system without active vops is obviously fine.


Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> index 48ddc43e2ab5..1883bd183396 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
> @@ -207,6 +207,10 @@ &cpu_l3 {
>  	cpu-supply = <&vdd_cpu_lit_s0>;
>  };
>  
> +&display_subsystem {
> +	status = "disabled";
> +};
> +
>  &i2c0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c0m2_xfer>;
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-09-18 17:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01 10:00 [PATCH v3 0/3] arm64: dts: rockchip: Update Radxa E52C support Chukun Pan
2025-09-01 10:00 ` Chukun Pan
2025-09-01 10:00 ` [PATCH v3 1/3] arm64: dts: rockchip: disable display subsystem for Radxa E52C Chukun Pan
2025-09-01 10:00   ` Chukun Pan
2025-09-18 17:31   ` Heiko Stübner [this message]
2025-09-18 17:31     ` Heiko Stübner
2025-09-28  7:00     ` Chukun Pan
2025-09-28  7:00       ` Chukun Pan
2025-09-01 10:00 ` [PATCH v3 2/3] arm64: dts: rockchip: remove vcc_3v3_pmu regulator " Chukun Pan
2025-09-01 10:00   ` Chukun Pan
2025-09-01 10:00 ` [PATCH v3 3/3] arm64: dts: rockchip: update pinctrl names " Chukun Pan
2025-09-01 10:00   ` Chukun Pan
2025-09-18  7:00 ` [PATCH v3 0/3] arm64: dts: rockchip: Update Radxa E52C support Chukun Pan
2025-09-18  7:00   ` Chukun Pan
2025-09-18 21:09 ` (subset) " Heiko Stuebner
2025-09-18 21:09   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10594621.0AQdONaE2F@diego \
    --to=heiko@sntech.de \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=naoki@radxa.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.