All of lore.kernel.org
 help / color / mirror / Atom feed
* Adding Deprecated Attribute Tags
@ 2003-11-13 13:32 Joseph D. Wagner
  0 siblings, 0 replies; 3+ messages in thread
From: Joseph D. Wagner @ 2003-11-13 13:32 UTC (permalink / raw)
  To: linux-fsdevel

I formally request that the struct ext2_dir_entry and ext3_dir_entry in the 
ext2_fs.h and ext3_fs.h files be changed to add the below specified 
attributes:

struct ext2_dir_entry {
	__u32	inode;			/* Inode number */
	__u16	rec_len;		/* Directory entry length */
	__u16	name_len;		/* Name length */
	char	name[EXT2_NAME_LEN];	/* File name */
} __attribute__ ((deprecated));

struct ext3_dir_entry {
	__u32	inode;			/* Inode number */
	__u16	rec_len;		/* Directory entry length */
	__u16	name_len;		/* Name length */
	char	name[EXT3_NAME_LEN];	/* File name */
} __attribute__ ((deprecated));

This will aid future development and debugging to ensure that everyone uses 
the new struct ext2_dir_entry_2 and can take advantage of the additional 
fields.

Joseph D. Wagner


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Adding Deprecated Attribute Tags
@ 2003-11-13 16:18 Joseph D. Wagner
  2003-11-14 18:01 ` Robert Love
  0 siblings, 1 reply; 3+ messages in thread
From: Joseph D. Wagner @ 2003-11-13 16:18 UTC (permalink / raw)
  To: linux-kernel

I formally request that the struct ext2_dir_entry and ext3_dir_entry in the 
ext2_fs.h and ext3_fs.h files be changed to add the below specified 
attributes:

struct ext2_dir_entry {
        __u32   inode;                  /* Inode number */
        __u16   rec_len;                /* Directory entry length */
        __u16   name_len;               /* Name length */
        char    name[EXT2_NAME_LEN];    /* File name */
} __attribute__ ((deprecated));

struct ext3_dir_entry {
        __u32   inode;                  /* Inode number */
        __u16   rec_len;                /* Directory entry length */
        __u16   name_len;               /* Name length */
        char    name[EXT3_NAME_LEN];    /* File name */
} __attribute__ ((deprecated));

This will aid future development and debugging to ensure that everyone uses 
the new struct ext2_dir_entry_2 and can take advantage of the additional 
fields.

Joseph D. Wagner


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Adding Deprecated Attribute Tags
  2003-11-13 16:18 Adding Deprecated Attribute Tags Joseph D. Wagner
@ 2003-11-14 18:01 ` Robert Love
  0 siblings, 0 replies; 3+ messages in thread
From: Robert Love @ 2003-11-14 18:01 UTC (permalink / raw)
  To: Joseph D. Wagner; +Cc: linux-kernel

On Thu, 2003-11-13 at 11:18, Joseph D. Wagner wrote:

> This will aid future development and debugging to ensure that everyone uses 
> the new struct ext2_dir_entry_2 and can take advantage of the additional 
> fields.

We have a special __deprecated define in include/compiler.h and family
to safely mark this (e.g., it defines away on older gcc's and Intel's
CC).

	Robert Love



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2003-11-14 18:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-13 16:18 Adding Deprecated Attribute Tags Joseph D. Wagner
2003-11-14 18:01 ` Robert Love
  -- strict thread matches above, loose matches on Subject: below --
2003-11-13 13:32 Joseph D. Wagner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.