All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] md: Remove unnecessary printk when raid5 gets an unaligned read.
       [not found] <20070125160528.21465.patches@notabene>
@ 2007-01-25  5:06 ` NeilBrown
  0 siblings, 0 replies; only message in thread
From: NeilBrown @ 2007-01-25  5:06 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-raid, linux-kernel

One more... (sorry about the dribs-and-drabs approach)
NeilBrown


### Comments for Changeset

raid5_mergeable_bvec tries to ensure that raid5 never sees a read
request that does not fit within just one chunk.  However as we
must always accept a single-page read, that is not always possible.

So when "in_chunk_boundary" fails, it might be unusual, but it is not
a problem and printing a message every time is a bad idea.

Signed-off-by: Neil Brown <neilb@suse.de>

### Diffstat output
 ./drivers/md/raid5.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff .prev/drivers/md/raid5.c ./drivers/md/raid5.c
--- .prev/drivers/md/raid5.c	2007-01-25 15:57:56.000000000 +1100
+++ ./drivers/md/raid5.c	2007-01-25 15:55:43.000000000 +1100
@@ -2630,7 +2630,7 @@ static int chunk_aligned_read(request_qu
 	mdk_rdev_t *rdev;
 
 	if (!in_chunk_boundary(mddev, raid_bio)) {
-		printk("chunk_aligned_read : non aligned\n");
+		PRINTK("chunk_aligned_read : non aligned\n");
 		return 0;
 	}
 	/*

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2007-01-25  5:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20070125160528.21465.patches@notabene>
2007-01-25  5:06 ` [PATCH] md: Remove unnecessary printk when raid5 gets an unaligned read NeilBrown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.