From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 002 of 5] md: 'sync_action' in sysfs returns wrong value for readonly arrays
Date: Mon, 15 Oct 2007 14:34:31 +1000 [thread overview]
Message-ID: <1071015043431.5463@suse.de> (raw)
In-Reply-To: 20071015143136.5200.patches@notabene
When an array is started read-only, MD_RECOVERY_NEEDED can be set but
no recovery will be running. This causes 'sync_action' to report the
wrong value.
We could remove the test for MD_RECOVERY_NEEDED, but doing so would
leave a small gap after requesting a sync action, where 'sync_action'
would still report the old value.
So make sure that for a read-only array, 'sync_action' always returns 'idle'.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff .prev/drivers/md/md.c ./drivers/md/md.c
--- .prev/drivers/md/md.c 2007-10-15 14:06:32.000000000 +1000
+++ ./drivers/md/md.c 2007-10-15 14:06:32.000000000 +1000
@@ -2714,7 +2714,7 @@ action_show(mddev_t *mddev, char *page)
{
char *type = "idle";
if (test_bit(MD_RECOVERY_RUNNING, &mddev->recovery) ||
- test_bit(MD_RECOVERY_NEEDED, &mddev->recovery)) {
+ (!mddev->ro && test_bit(MD_RECOVERY_NEEDED, &mddev->recovery))) {
if (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery))
type = "reshape";
else if (test_bit(MD_RECOVERY_SYNC, &mddev->recovery)) {
next prev parent reply other threads:[~2007-10-15 4:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 4:34 [PATCH 000 of 5] md: Five minor md patch, some for 2.6.24 NeilBrown
2007-10-15 4:34 ` NeilBrown
2007-10-15 4:34 ` [PATCH 001 of 5] md: Fix a bug in some never-used code NeilBrown
2007-10-15 4:34 ` NeilBrown [this message]
2007-10-15 4:34 ` [PATCH 003 of 5] md: Expose the degraded status of an assembled array through sysfs NeilBrown
2007-10-15 4:34 ` NeilBrown
2007-10-15 4:34 ` [PATCH 004 of 5] md: Make sure read errors are auto-corrected during a 'check' resync in raid1 NeilBrown
2007-10-15 4:34 ` [PATCH 005 of 5] md: Fix type that is stopping raid5 grow from working NeilBrown
2007-10-15 4:34 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1071015043431.5463@suse.de \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.