From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: [PATCH 005 of 5] md: Fix type that is stopping raid5 grow from working.
Date: Mon, 15 Oct 2007 14:34:49 +1000 [thread overview]
Message-ID: <1071015043449.5545@suse.de> (raw)
In-Reply-To: 20071015143136.5200.patches@notabene
This kmem_cache_create is creating a cache that already exists. We
could us the alternate name, just like we do a few lines up.
Signed-off-by: Neil Brown <neilb@suse.de>
Cc: "Dan Williams" <dan.j.williams@intel.com>
### Diffstat output
./drivers/md/raid5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff .prev/drivers/md/raid5.c ./drivers/md/raid5.c
--- .prev/drivers/md/raid5.c 2007-10-15 14:12:03.000000000 +1000
+++ ./drivers/md/raid5.c 2007-10-15 14:12:06.000000000 +1000
@@ -1380,7 +1380,7 @@ static int resize_stripes(raid5_conf_t *
if (!sc)
return -ENOMEM;
- sc_q = kmem_cache_create(conf->sq_cache_name[conf->active_name],
+ sc_q = kmem_cache_create(conf->sq_cache_name[1-conf->active_name],
(sizeof(struct stripe_queue)+(newsize-1) *
sizeof(struct r5_queue_dev)) +
r5_io_weight_size(newsize) +
WARNING: multiple messages have this Message-ID (diff)
From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Dan Williams" <dan.j.williams@intel.com>
Subject: [PATCH 005 of 5] md: Fix type that is stopping raid5 grow from working.
Date: Mon, 15 Oct 2007 14:34:49 +1000 [thread overview]
Message-ID: <1071015043449.5545@suse.de> (raw)
In-Reply-To: 20071015143136.5200.patches@notabene
This kmem_cache_create is creating a cache that already exists. We
could us the alternate name, just like we do a few lines up.
Signed-off-by: Neil Brown <neilb@suse.de>
Cc: "Dan Williams" <dan.j.williams@intel.com>
### Diffstat output
./drivers/md/raid5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff .prev/drivers/md/raid5.c ./drivers/md/raid5.c
--- .prev/drivers/md/raid5.c 2007-10-15 14:12:03.000000000 +1000
+++ ./drivers/md/raid5.c 2007-10-15 14:12:06.000000000 +1000
@@ -1380,7 +1380,7 @@ static int resize_stripes(raid5_conf_t *
if (!sc)
return -ENOMEM;
- sc_q = kmem_cache_create(conf->sq_cache_name[conf->active_name],
+ sc_q = kmem_cache_create(conf->sq_cache_name[1-conf->active_name],
(sizeof(struct stripe_queue)+(newsize-1) *
sizeof(struct r5_queue_dev)) +
r5_io_weight_size(newsize) +
next prev parent reply other threads:[~2007-10-15 4:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-15 4:34 [PATCH 000 of 5] md: Five minor md patch, some for 2.6.24 NeilBrown
2007-10-15 4:34 ` NeilBrown
2007-10-15 4:34 ` [PATCH 001 of 5] md: Fix a bug in some never-used code NeilBrown
2007-10-15 4:34 ` [PATCH 002 of 5] md: 'sync_action' in sysfs returns wrong value for readonly arrays NeilBrown
2007-10-15 4:34 ` [PATCH 003 of 5] md: Expose the degraded status of an assembled array through sysfs NeilBrown
2007-10-15 4:34 ` NeilBrown
2007-10-15 4:34 ` [PATCH 004 of 5] md: Make sure read errors are auto-corrected during a 'check' resync in raid1 NeilBrown
2007-10-15 4:34 ` NeilBrown [this message]
2007-10-15 4:34 ` [PATCH 005 of 5] md: Fix type that is stopping raid5 grow from working NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1071015043449.5545@suse.de \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.