From: Michael Neuling <mikey@neuling.org>
To: Carl Love <cel@us.ibm.com>
Cc: linuxppc-dev@ozlabs.org, cbe-oss-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CELL PPU Oprofile cleanup patch
Date: Fri, 02 Feb 2007 09:52:28 +1100 [thread overview]
Message-ID: <10720.1170370348@neuling.org> (raw)
In-Reply-To: <1170360615.5204.18.camel@dyn9047021078.beaverton.ibm.com>
Carl,
> +#define NUM_TRACE_BUS_WORDS 4
> +#define NUM_INPUT_BUS_WORDS 2
<snip>
> - for (i = 0; i < 4; i++)
> + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> trace_bus[i] = 0xff;
>
> - for (i = 0; i < 2; i++)
> + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> input_bus[i] = 0xff;
The first loop looks like a bug... Shouldn't it be NUM_TRACE_BUS_WORDS?
Mikey
WARNING: multiple messages have this Message-ID (diff)
From: Michael Neuling <mikey@neuling.org>
To: Carl Love <cel@us.ibm.com>
Cc: cbe-oss-dev@ozlabs.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CELL PPU Oprofile cleanup patch
Date: Fri, 02 Feb 2007 09:52:28 +1100 [thread overview]
Message-ID: <10720.1170370348@neuling.org> (raw)
In-Reply-To: <1170360615.5204.18.camel@dyn9047021078.beaverton.ibm.com>
Carl,
> +#define NUM_TRACE_BUS_WORDS 4
> +#define NUM_INPUT_BUS_WORDS 2
<snip>
> - for (i = 0; i < 4; i++)
> + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> trace_bus[i] = 0xff;
>
> - for (i = 0; i < 2; i++)
> + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> input_bus[i] = 0xff;
The first loop looks like a bug... Shouldn't it be NUM_TRACE_BUS_WORDS?
Mikey
next prev parent reply other threads:[~2007-02-01 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 20:10 [PATCH] CELL PPU Oprofile cleanup patch Carl Love
2007-02-01 22:52 ` Michael Neuling [this message]
2007-02-01 22:52 ` Michael Neuling
2007-02-01 23:15 ` Carl Love
2007-02-01 23:15 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10720.1170370348@neuling.org \
--to=mikey@neuling.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=cel@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.