RE: [SchreiberX@Altmuehlnet.de: Re: hp omnibook xe4500 hangs while loading acpi module]

RE: [SchreiberX@Altmuehlnet.de: Re: hp omnibook xe4500 hangs while loading acpi module]

[Brown, Len]

This was  http://bugzilla.kernel.org/show_bug.cgi?id=1349
The fix is in current 2.4.24, and the latest ACPI patch for 2.6.0:

http://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/
2.6.0/

Cheers,
-Len

Ps. Sorry I didn't reply earlier, I got bounced off this list for a
spell.


> -----Original Message-----
> From: Dominik Brodowski [mailto:linux@dominikbrodowski.de] 
> Sent: Saturday, December 20, 2003 12:15 PM
> To: Brown, Len
> Cc: cpufreq@www.linux.org.uk
> Subject: [SchreiberX@Altmuehlnet.de: Re: hp omnibook xe4500 
> hangs while loading acpi module]
> 
> 
> Hi Len,
> 
> The patch "[ACPI] GV3 IO port is 16-bits" to the
> arch/i386/kernel/cpu/cpufreq/acpi.c file broke at least some of 
> the GV1/2 support. Any idea on how to fix it up so that it works
> for both?
> 
> Happy holidays,
> 	Dominik
> 
> ----- Forwarded message from Martin Schreiber 
> <SchreiberX@Altmuehlnet.de> -----
> 
> Subject: Re: hp omnibook xe4500 hangs while loading acpi module
> From: Martin Schreiber <SchreiberX@Altmuehlnet.de>
> To: Dominik Brodowski <linux@dominikbrodowski.de>
> Cc: cpufreq@www.linux.org.uk
> In-Reply-To: <20031219182737.GE6909@dominikbrodowski.de>
> X-Mailer: Ximian Evolution 1.4.5 
> Date: Sat, 20 Dec 2003 17:13:47 +0100
> 
> the acpi cpufreq (kernel 2.6.0) works now on omnibook xe4500 with the
> attached patch.
> 
> thanks!
> 
> 
> 
> On Fri, 2003-12-19 at 19:27, Dominik Brodowski wrote:
> > Hi,
> > 
> > Can you please try the attached patch (for 2.6.0)? It 
> reverts a change
> > done during the time frame you mention: I assume this patch
> > "[ACPI] GV3 IO port is 16-bits (Venkatesh Pallipadi)" 
> caused the trouble.
> > Please CC <cpufreq@www.linux.org.uk> in your reply [the 
> cpufreq mailing 
> > list], so that other cpufreq developers can investigate 
> this issue as well.
> > 
> > Thanks,
> > 	Dominik

Re: [SchreiberX@Altmuehlnet.de: Re: hp omnibook xe4500 hangs while loading acpi module]

[Dominik Brodowski]

[-- Attachment #1.1: Type: text/plain, Size: 464 bytes --]

On Tue, Dec 23, 2003 at 01:31:30AM -0500, Brown, Len wrote:
> This was  http://bugzilla.kernel.org/show_bug.cgi?id=1349
> The fix is in current 2.4.24, and the latest ACPI patch for 2.6.0:
> 
> http://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/
> 2.6.0/
> 
> Cheers,
> -Len
> 
> Ps. Sorry I didn't reply earlier, I got bounced off this list for a
> spell.

AFAICS, Veki's patch isn't in acpi-20031203-2.6.0.diff.gz.

	Dominik

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@www.linux.org.uk
http://www.linux.org.uk/mailman/listinfo/cpufreq

Re: [SchreiberX@Altmuehlnet.de: Re: hp omnibook xe4500 hangs while loading acpi module]

[Len Brown]

On Mon, 2003-12-29 at 06:56, Dominik Brodowski wrote:
> On Tue, Dec 23, 2003 at 01:31:30AM -0500, Brown, Len wrote:
> > This was  http://bugzilla.kernel.org/show_bug.cgi?id=1349
> > The fix is in current 2.4.24, and the latest ACPI patch for 2.6.0:
> > 
> > http://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/
> > 2.6.0/
> > 
> > Cheers,
> > -Len
> > 
> > Ps. Sorry I didn't reply earlier, I got bounced off this list for a
> > spell.
> 
> AFAICS, Veki's patch isn't in acpi-20031203-2.6.0.diff.gz.
> 
> 	Dominik

oops -- looks like i applied it to 24 but didn't roll in the 26 version.

Here's the broken out 26 patch -- it will be rolled in tonight.

http://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/test/2.6.0/20040115170330-processor.patch

thanks,
-Len

[SchreiberX@Altmuehlnet.de: Re: hp omnibook xe4500 hangs while loading acpi module]

[Dominik Brodowski]

Hi Len,

The patch "[ACPI] GV3 IO port is 16-bits" to the
arch/i386/kernel/cpu/cpufreq/acpi.c file broke at least some of 
the GV1/2 support. Any idea on how to fix it up so that it works
for both?

Happy holidays,
	Dominik

----- Forwarded message from Martin Schreiber <SchreiberX@Altmuehlnet.de> -----

Subject: Re: hp omnibook xe4500 hangs while loading acpi module
From: Martin Schreiber <SchreiberX@Altmuehlnet.de>
To: Dominik Brodowski <linux@dominikbrodowski.de>
Cc: cpufreq@www.linux.org.uk
In-Reply-To: <20031219182737.GE6909@dominikbrodowski.de>
X-Mailer: Ximian Evolution 1.4.5 
Date: Sat, 20 Dec 2003 17:13:47 +0100

the acpi cpufreq (kernel 2.6.0) works now on omnibook xe4500 with the
attached patch.

thanks!



On Fri, 2003-12-19 at 19:27, Dominik Brodowski wrote:
> Hi,
> 
> Can you please try the attached patch (for 2.6.0)? It reverts a change
> done during the time frame you mention: I assume this patch
> "[ACPI] GV3 IO port is 16-bits (Venkatesh Pallipadi)" caused the trouble.
> Please CC <cpufreq@www.linux.org.uk> in your reply [the cpufreq mailing 
> list], so that other cpufreq developers can investigate this issue as well.
> 
> Thanks,
> 	Dominik
> 
> On Thu, Nov 27, 2003 at 11:24:45PM +0100, Martin Schreiber wrote:
> > hi!
> > 
> > my "hp omnibook xe4500" hangs, if i load the acpi module for cpufreq.
> > there's no kernel error message. it just blocks everything.
> > 
> > the cpufreq works fine up to test-6
> > with test-7, the kernel hangs, if i load the module.
> > 
> > can i help you, to fix this problem?
> > 
> > just say, what you need.
> > 
> > i'm completely new to the kernel!
> > 
> > ciao,
> >   martini
> > 
> > 
> > Martin Schreiber
> > Im Muehltal 48
> > 91171 Greding
> > 
> > http://www.martin-schreiber.net
> > SchreiberX@Altmuehlnet.de
> > 
> > Stürmt und schneit's Silvester nicht, ist das Neujahr auch in Sicht.
> > 
> > --BEGIN GEEK CODE BLOCK--
> > Version: 3.12
> > GCS d s+: a-- C++ UL++ P+ L+++ E-- W+++ N o K- w--
> > O- M- V- PS+++ PE+ Y PGP++ t 5+ X R+ tv++ b+ DI- D++
> > G e h-- r-- y+
> > --END GEEK CODE BLOCK--


Martin Schreiber
Im Muehltal 48
91171 Greding

http://www.martin-schreiber.net
SchreiberX@Altmuehlnet.de

Wenn du kritisiert wirst, dann mußt du irgend etwas richtig machen.
Denn man greift nur denjenigen an, der den Ball hat.
-- Bruce Lee

-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCS d s+: a-- C++ UL++ P+ L+++ E-- W+++ N o K- w---
O- M- V- PS+++ PE+ Y PGP++ t 5+ X R+ tv++ b+ DI- D++
G e h-- r-- y+
------END GEEK CODE BLOCK------

--- linux/arch/i386/kernel/cpu/cpufreq/acpi.c	2003-10-12 19:48:39.000000000 +0200
+++ linux-tmp/arch/i386/kernel/cpu/cpufreq/acpi.c	2003-12-19 17:42:33.076814176 +0100
@@ -231,7 +231,7 @@
 	int			state)
 {
 	u16			port = 0;
-	u16			value = 0;
+	u8			value = 0;
 	int			i = 0;
 	struct cpufreq_freqs    cpufreq_freqs;
 
@@ -282,9 +282,9 @@
 	value = (u16) perf->states[state].control;
 
 	ACPI_DEBUG_PRINT((ACPI_DB_INFO, 
-		"Writing 0x%04x to port 0x%04x\n", value, port));
+		"Writing 0x%02x to port 0x%02x\n", value, port));
 
-	outw(value, port); 
+	outb(value, port); 
 
 	/*
 	 * Then we read the 'status_register' and compare the value with the
@@ -296,11 +296,11 @@
 	port = perf->status_register;
 
 	ACPI_DEBUG_PRINT((ACPI_DB_INFO, 
-		"Looking for 0x%04x from port 0x%04x\n",
-		(u16) perf->states[state].status, port));
+		"Looking for 0x%02x from port 0x%02x\n",
+		(u8) perf->states[state].status, port));
 
 	for (i=0; i<100; i++) {
-		value = inw(port);
+		value = inb(port);
 		if (value == (u16) perf->states[state].status)
 			break;
 		udelay(10);
@@ -309,7 +309,7 @@
 	/* notify cpufreq */
 	cpufreq_notify_transition(&cpufreq_freqs, CPUFREQ_POSTCHANGE);
 
-	if (value != (u16) perf->states[state].status) {
+	if (value != perf->states[state].status) {
 		unsigned int tmp = cpufreq_freqs.new;
 		cpufreq_freqs.new = cpufreq_freqs.old;
 		cpufreq_freqs.old = tmp;




----- End forwarded message -----