From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH-next 1/6] batman-adv: ignore netdev_set_master() calls on kernels older than 2.6.39
Date: Mon, 20 Apr 2015 11:32:23 +0800 [thread overview]
Message-ID: <10750000.oymJvT72oN@voltaire> (raw)
In-Reply-To: <1429288461-26260-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On Friday, April 17, 2015 18:34:16 Sven Eckelmann wrote:
> From: Marek Lindner <mareklindner@neomailbox.ch>
>
> batman-adv calls netdev_master_upper_dev_link() which is replaced with with
> netdev_set_master() for kernels older than 3.9 via compat.h.
> Prior to 2.6.39 netdev_set_master() contained Linux bonding calls needed to
> setup bonding devices. Calling this function from batman-adv leads to
> unexpected behavior when current batman-adv versions are used on these
> older kernels.
>
> To fix the situation compat.h now ships its own implementation of
> netdev_set_master() which does not change the net_dev->master state
> on kernels older than 2.6.39.
>
> Reported-by: Andreas Pape <APape@phoenixcontact.com>
> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> compat.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
I have already cherry-picked that patch myself.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-20 3:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 16:32 [B.A.T.M.A.N.] [PATCH-next 0/6] Patches for batman-adv 2015.0 release Sven Eckelmann
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 1/6] batman-adv: ignore netdev_set_master() calls on kernels older than 2.6.39 Sven Eckelmann
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 2/6] batman-adv: replace strnicmp with strncasecmp Sven Eckelmann
2015-04-20 3:34 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 3/6] batman-adv: Use kasprintf Sven Eckelmann
2015-04-20 3:37 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 4/6] dev: introduce dev_get_iflink() Sven Eckelmann
2015-04-17 16:40 ` [B.A.T.M.A.N.] [PATCH-nextv2 " Sven Eckelmann
2015-04-17 17:15 ` [B.A.T.M.A.N.] [PATCH-nextv2 4/6] batman-adv: " Sven Eckelmann
2015-04-20 3:38 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 5/6] Revert "batman-adv: fix var name to keep compatibility with old kernels" Sven Eckelmann
2015-04-17 17:18 ` [B.A.T.M.A.N.] [PATCH-nextv2 5/6] batman-adv: Revert "fix " Sven Eckelmann
2015-04-20 14:06 ` Antonio Quartulli
2015-04-20 15:23 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 6/6] batman-adv: Use kernel variable declaration order in batadv_send_skb_unicast Sven Eckelmann
2015-04-20 15:27 ` Marek Lindner
2015-04-20 16:05 ` Sven Eckelmann
2015-04-21 8:16 ` Antonio Quartulli
2015-04-20 3:32 ` Marek Lindner [this message]
2015-04-20 6:11 ` [B.A.T.M.A.N.] [PATCH-next 1/6] batman-adv: ignore netdev_set_master() calls on kernels older than 2.6.39 Sven Eckelmann
2015-04-20 6:24 ` Marek Lindner
2015-04-17 18:03 ` [B.A.T.M.A.N.] [PATCH-next 0/6] Patches for batman-adv 2015.0 release Sven Eckelmann
2015-04-20 17:25 ` Sven Eckelmann
2015-04-20 3:23 ` Marek Lindner
2015-04-20 6:05 ` Sven Eckelmann
2015-04-20 6:30 ` Marek Lindner
2015-04-20 12:05 ` Antonio Quartulli
2015-04-20 12:12 ` Sven Eckelmann
2015-04-20 12:22 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10750000.oymJvT72oN@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.