From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org, antonio@meshcoding.com
Subject: Re: [B.A.T.M.A.N.] [PATCH-next 0/6] Patches for batman-adv 2015.0 release
Date: Mon, 20 Apr 2015 11:23:15 +0800 [thread overview]
Message-ID: <6809018.15Hlry5Imp@voltaire> (raw)
In-Reply-To: <13114664.Eg4ODy7KEo@bentobox>
[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]
Sven,
thanks for the thorough cleanup review.
> Patches which are in batman-adv master but should be in this release:
>
> *
> http://git.open-mesh.org/batman-adv.git/commit/3f74f359cb7e96bbc68d62e1fc48
> b04b6efb4ca7
I moved the patch to main (not strictly necessary as maint will be replaced
soon) and merge my way up to master.
> A patch which should never ever have existed in the first place (please
> correct me when I've missed the actual problem):
>
> *
> http://git.open-mesh.org/linux-merge.git/commit/b53915310227cc9b029ba0fa5aa
> e44e50a461f80
This (subtle) problem is about compat.h. Specifically, the kfree_rcu macro
requires a pre-defined variable name:
#define kfree_rcu(ptr, rcu_head) call_rcu(&ptr->rcu_head,
batadv_free_rcu_##ptr)
void batadv_free_rcu_softif_vlan(struct rcu_head *rcu);
> The weirdest commit is one which is in batman-adv next but can nowhere be
> found in the kernel trees. It is already part of the release v2014.2.0:
>
> *
> http://git.open-mesh.org/batman-adv.git/commit/31f391475cc08724e96ab060ef4a
> a6503d11da8e (havent touched this commit because this is just too weird)
Antonio, can you comment ? Was it forgotten or was there a reason ?
Cheers,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-20 3:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 16:32 [B.A.T.M.A.N.] [PATCH-next 0/6] Patches for batman-adv 2015.0 release Sven Eckelmann
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 1/6] batman-adv: ignore netdev_set_master() calls on kernels older than 2.6.39 Sven Eckelmann
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 2/6] batman-adv: replace strnicmp with strncasecmp Sven Eckelmann
2015-04-20 3:34 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 3/6] batman-adv: Use kasprintf Sven Eckelmann
2015-04-20 3:37 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 4/6] dev: introduce dev_get_iflink() Sven Eckelmann
2015-04-17 16:40 ` [B.A.T.M.A.N.] [PATCH-nextv2 " Sven Eckelmann
2015-04-17 17:15 ` [B.A.T.M.A.N.] [PATCH-nextv2 4/6] batman-adv: " Sven Eckelmann
2015-04-20 3:38 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 5/6] Revert "batman-adv: fix var name to keep compatibility with old kernels" Sven Eckelmann
2015-04-17 17:18 ` [B.A.T.M.A.N.] [PATCH-nextv2 5/6] batman-adv: Revert "fix " Sven Eckelmann
2015-04-20 14:06 ` Antonio Quartulli
2015-04-20 15:23 ` Marek Lindner
2015-04-17 16:34 ` [B.A.T.M.A.N.] [PATCH-next 6/6] batman-adv: Use kernel variable declaration order in batadv_send_skb_unicast Sven Eckelmann
2015-04-20 15:27 ` Marek Lindner
2015-04-20 16:05 ` Sven Eckelmann
2015-04-21 8:16 ` Antonio Quartulli
2015-04-20 3:32 ` [B.A.T.M.A.N.] [PATCH-next 1/6] batman-adv: ignore netdev_set_master() calls on kernels older than 2.6.39 Marek Lindner
2015-04-20 6:11 ` Sven Eckelmann
2015-04-20 6:24 ` Marek Lindner
2015-04-17 18:03 ` [B.A.T.M.A.N.] [PATCH-next 0/6] Patches for batman-adv 2015.0 release Sven Eckelmann
2015-04-20 17:25 ` Sven Eckelmann
2015-04-20 3:23 ` Marek Lindner [this message]
2015-04-20 6:05 ` Sven Eckelmann
2015-04-20 6:30 ` Marek Lindner
2015-04-20 12:05 ` Antonio Quartulli
2015-04-20 12:12 ` Sven Eckelmann
2015-04-20 12:22 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6809018.15Hlry5Imp@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.