All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Paul Herbert <kph@cisco.com>
To: linux-mips@linux-mips.org
Subject: Removal of ____raw_readq() and ____raw_writeq() from asm-mips/io.h
Date: 27 Jan 2004 17:58:31 -0800	[thread overview]
Message-ID: <1075255111.8744.4.camel@shakedown> (raw)

In edit 1.68, the non-interrupt locking versions of
raw_readq()/raw_writeq() were removed, in favor of locking ones. While
this makes sense in general, it breaks the compilation of the sb1250
which uses the non-locking versions (____raw_readq() and
____raw_writeq()) in interrupt handlers.

Personally, I think that it is very confusing to have so many similar
macros with similar names and increasing numbers of underscores, so I
don't really have a problem with this. I've modified
arch/mips/sibyte/sb1250/time.c and arch/mips/sibyte/sb1250/irq.c to use
the __ versions and have a few more instructions of overhead.

My question is whether this removal was intended or not, or whether
there are some other changes to the handlers in the sb1250-specific code
that got dropped somewhere.

If the consensus is that the ____ versions really should perish for the
sake of simplicity, I'll send my simple patches to the list to fix the
sb1250 build.

Thanks,
Kevin
-- 
Kevin Paul Herbert <kph@cisco.com>
cisco Systems, Inc.

             reply	other threads:[~2004-01-28  1:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-28  1:58 Kevin Paul Herbert [this message]
2004-01-28  9:40 ` Removal of ____raw_readq() and ____raw_writeq() from asm-mips/io.h Ladislav Michl
2004-01-28 10:49   ` Jes Sorensen
2004-01-28 15:08     ` Ladislav Michl
2004-01-28 16:01       ` Ralf Baechle
2004-01-29 10:35       ` Jes Sorensen
2004-01-28 14:30 ` Ralf Baechle
2004-01-28 15:00   ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1075255111.8744.4.camel@shakedown \
    --to=kph@cisco.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.