From: Jes Sorensen <jes@wildopensource.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: Kevin Paul Herbert <kph@cisco.com>, linux-mips@linux-mips.org
Subject: Re: Removal of ____raw_readq() and ____raw_writeq() from asm-mips/io.h
Date: 29 Jan 2004 05:35:47 -0500 [thread overview]
Message-ID: <yq0znc79h4s.fsf@wildopensource.com> (raw)
In-Reply-To: <20040128150828.A19525@linux-mips.org>
>>>>> "Ladislav" == Ladislav Michl <ladis@linux-mips.org> writes:
Ladislav> On Wed, Jan 28, 2004 at 05:49:58AM -0500, Jes Sorensen
Ladislav> wrote:
>> If you are accessing memory mapped registers or memory on a PCI
>> device, ie. likely on a 1250, you *must* use the readX/__raw_readX
>> macros. Anybody just doing *reg = val on a PCI device should be
>> banned from writing code for life!
Ladislav> eh? I said nothing about PCI device. These ____raw_writeq
Ladislav> are used in board specific code. Anyway, defining struct
Ladislav> sb_registers and ioremaping it would be nice solution (I
Ladislav> didn't read code too carefully, so maybye not in this
Ladislav> particular case where registers are 64bit width, but I
Ladislav> definitely prefer it in board specific code over
Ladislav> read[bwl]/write[bwl]). Also readq/writeq seems mips
Ladislav> specific, so rants about portability doesn't apply.
Very wrong!
the readX/writeX macro names are for PCI and busses with similar
properties. One should never access anything through readX/writeX
without ioremaping it first.
readq/writeq are not mips specific, they are available on all/most 64
bit architectures, so portability rants do apply.
Jes
next prev parent reply other threads:[~2004-01-29 10:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-28 1:58 Removal of ____raw_readq() and ____raw_writeq() from asm-mips/io.h Kevin Paul Herbert
2004-01-28 9:40 ` Ladislav Michl
2004-01-28 10:49 ` Jes Sorensen
2004-01-28 15:08 ` Ladislav Michl
2004-01-28 16:01 ` Ralf Baechle
2004-01-29 10:35 ` Jes Sorensen [this message]
2004-01-28 14:30 ` Ralf Baechle
2004-01-28 15:00 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0znc79h4s.fsf@wildopensource.com \
--to=jes@wildopensource.com \
--cc=kph@cisco.com \
--cc=ladis@linux-mips.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.