From: Jens Axboe <axboe@kernel.dk>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: linux-sh@vger.kernel.org,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>
Subject: Re: [PATCH] sh: add support for TIF_NOTIFY_SIGNAL
Date: Fri, 01 Jan 2021 15:35:40 +0000 [thread overview]
Message-ID: <10752e73-ca2a-9ea7-4aa6-35e366e36fb0@kernel.dk> (raw)
In-Reply-To: <f95539e9-506b-c4d9-2861-f288e2d021df@physik.fu-berlin.de>
On 1/1/21 8:30 AM, John Paul Adrian Glaubitz wrote:
> Hi Jens!
>
> On 1/1/21 4:08 PM, Jens Axboe wrote:
>> On 1/1/21 7:06 AM, John Paul Adrian Glaubitz wrote:
>>> Is there away to test the change itself?
>>
>> The only user of TWA_SIGNAL, which uses TIF_NOTIFY_SIGNAL, so far is io_uring.
>> You need something that triggers deferred task_work processing, which is
>> basically anything that ends up being poll driven for data/space readiness.
>> Here's a small test app from the liburing test suite, that'll trigger it.
>>
>> If you install liburing, compile with:
>>
>> gcc -Wall -O2 -o socket-rw socket-rw.c -luring
>>
>> and run it without any arguments.
>
> How long is this test supposed to run? It's already been running for some minutes
> on my 600 MHz machine.
It's supposed to finish very quickly:
axboe@p1 ~> time ./socket-rw 0.000s
________________________________________________________
Executed in 1.10 millis fish external
usr time 888.00 micros 278.00 micros 610.00 micros
sys time 35.00 micros 35.00 micros 0.00 micros
If it doesn't, can you try:
# echo 1 > /sys/kernel/debug/tracing/events/io_uring/enable
Then run the socket-rw app, and then do:
# cat /sys/kernel/debug/tracing/trace
and send that output? Might also be useful to include the strace
of the socket-rw just in case, so maybe run it ala
strace -o foo ./socket-rw
and include foo in the reply as well.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: linux-sh@vger.kernel.org,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>
Subject: Re: [PATCH] sh: add support for TIF_NOTIFY_SIGNAL
Date: Fri, 1 Jan 2021 08:35:40 -0700 [thread overview]
Message-ID: <10752e73-ca2a-9ea7-4aa6-35e366e36fb0@kernel.dk> (raw)
In-Reply-To: <f95539e9-506b-c4d9-2861-f288e2d021df@physik.fu-berlin.de>
On 1/1/21 8:30 AM, John Paul Adrian Glaubitz wrote:
> Hi Jens!
>
> On 1/1/21 4:08 PM, Jens Axboe wrote:
>> On 1/1/21 7:06 AM, John Paul Adrian Glaubitz wrote:
>>> Is there away to test the change itself?
>>
>> The only user of TWA_SIGNAL, which uses TIF_NOTIFY_SIGNAL, so far is io_uring.
>> You need something that triggers deferred task_work processing, which is
>> basically anything that ends up being poll driven for data/space readiness.
>> Here's a small test app from the liburing test suite, that'll trigger it.
>>
>> If you install liburing, compile with:
>>
>> gcc -Wall -O2 -o socket-rw socket-rw.c -luring
>>
>> and run it without any arguments.
>
> How long is this test supposed to run? It's already been running for some minutes
> on my 600 MHz machine.
It's supposed to finish very quickly:
axboe@p1 ~> time ./socket-rw 0.000s
________________________________________________________
Executed in 1.10 millis fish external
usr time 888.00 micros 278.00 micros 610.00 micros
sys time 35.00 micros 35.00 micros 0.00 micros
If it doesn't, can you try:
# echo 1 > /sys/kernel/debug/tracing/events/io_uring/enable
Then run the socket-rw app, and then do:
# cat /sys/kernel/debug/tracing/trace
and send that output? Might also be useful to include the strace
of the socket-rw just in case, so maybe run it ala
strace -o foo ./socket-rw
and include foo in the reply as well.
--
Jens Axboe
next prev parent reply other threads:[~2021-01-01 15:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 16:21 [PATCH] sh: add support for TIF_NOTIFY_SIGNAL Jens Axboe
2020-11-05 16:17 ` Jens Axboe
2020-11-05 16:20 ` John Paul Adrian Glaubitz
2020-11-05 17:15 ` Jens Axboe
2020-11-09 8:15 ` Rob Landley
2020-11-09 10:59 ` John Paul Adrian Glaubitz
2020-11-09 14:14 ` Jens Axboe
2020-11-09 14:14 ` Jens Axboe
2020-11-09 15:10 ` Jens Axboe
2020-11-09 15:15 ` Rob Landley
2020-11-09 16:29 ` Jens Axboe
2020-11-09 16:34 ` Rob Landley
2020-11-17 5:26 ` John Paul Adrian Glaubitz
2020-11-17 15:06 ` Jens Axboe
2021-01-01 14:06 ` John Paul Adrian Glaubitz
2021-01-01 14:06 ` John Paul Adrian Glaubitz
2021-01-01 15:08 ` Jens Axboe
2021-01-01 15:08 ` Jens Axboe
2021-01-01 15:30 ` John Paul Adrian Glaubitz
2021-01-01 15:30 ` John Paul Adrian Glaubitz
2021-01-01 15:35 ` Jens Axboe [this message]
2021-01-01 15:35 ` Jens Axboe
2021-01-01 18:16 ` John Paul Adrian Glaubitz
2021-01-01 18:16 ` John Paul Adrian Glaubitz
2021-01-01 18:22 ` Jens Axboe
2021-01-01 18:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10752e73-ca2a-9ea7-4aa6-35e366e36fb0@kernel.dk \
--to=axboe@kernel.dk \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.