All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Vagrant Cascadian <vagrant@debian.org>,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Pierre-Hugues Husson <phh@phh.me>,
	Jianqun Xu <jay.xu@rock-chips.com>,
	Kever Yang <kever.yang@rock-chips.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: correct voltage selector Firefly-RK3399
Date: Wed, 20 Jun 2018 01:21:31 +0200	[thread overview]
Message-ID: <10782218.jfpm9omiT7@phil> (raw)
In-Reply-To: <19360053.2ABrQ075F2@phil>

Hi Heinrich,

Am Donnerstag, 14. Juni 2018, 14:55:27 CEST schrieb Heiko Stuebner:
> Am Montag, 4. Juni 2018, 19:15:23 CEST schrieb Heinrich Schuchardt:
> > Without this patch the Firefly-RK3399 board boot process hangs after these
> > lines:
> > 
> >    fan53555-regulator 0-0040: FAN53555 Option[8] Rev[1] Detected!
> >    fan53555-reg: supplied by vcc_sys
> >    vcc1v8_s3: supplied by vcc_1v8
> > 
> > Blacklisting driver fan53555 allows booting.
> > 
> > The device tree uses a value of fcs,suspend-voltage-selector different to
> > any other board.
> > 
> > Changing this setting to the usual value is sufficient to enable booting.
> > 
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> 
> applied for 4.19.

and dropped again.

Sadly it looks like the patch causes conflicts with at least one firefly
board in a kernelci lab. My own is currently not ready to use, so I cannot
look myself right now.

The issue kernelci people described sounded quite a lot like the one
in your commit message, so my current theory is that the
suspend-voltage-selector must in some form corespond to the
cpu_b_sleep_h gpio setting we're currently not handling at all, which
would therefore depend on how the bootloader sets this up.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] arm64: dts: rockchip: correct voltage selector Firefly-RK3399
Date: Wed, 20 Jun 2018 01:21:31 +0200	[thread overview]
Message-ID: <10782218.jfpm9omiT7@phil> (raw)
In-Reply-To: <19360053.2ABrQ075F2@phil>

Hi Heinrich,

Am Donnerstag, 14. Juni 2018, 14:55:27 CEST schrieb Heiko Stuebner:
> Am Montag, 4. Juni 2018, 19:15:23 CEST schrieb Heinrich Schuchardt:
> > Without this patch the Firefly-RK3399 board boot process hangs after these
> > lines:
> > 
> >    fan53555-regulator 0-0040: FAN53555 Option[8] Rev[1] Detected!
> >    fan53555-reg: supplied by vcc_sys
> >    vcc1v8_s3: supplied by vcc_1v8
> > 
> > Blacklisting driver fan53555 allows booting.
> > 
> > The device tree uses a value of fcs,suspend-voltage-selector different to
> > any other board.
> > 
> > Changing this setting to the usual value is sufficient to enable booting.
> > 
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> 
> applied for 4.19.

and dropped again.

Sadly it looks like the patch causes conflicts with at least one firefly
board in a kernelci lab. My own is currently not ready to use, so I cannot
look myself right now.

The issue kernelci people described sounded quite a lot like the one
in your commit message, so my current theory is that the
suspend-voltage-selector must in some form corespond to the
cpu_b_sleep_h gpio setting we're currently not handling at all, which
would therefore depend on how the bootloader sets this up.


Heiko

  reply	other threads:[~2018-06-19 23:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 17:15 [PATCH 1/1] arm64: dts: rockchip: correct voltage selector Firefly-RK3399 Heinrich Schuchardt
2018-06-04 17:15 ` Heinrich Schuchardt
2018-06-04 17:15 ` Heinrich Schuchardt
     [not found] ` <20180604171523.28454-1-xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
2018-06-04 21:45   ` Heinrich Schuchardt
2018-06-04 21:45     ` Heinrich Schuchardt
2018-06-04 21:45     ` Heinrich Schuchardt
2018-06-14 12:55 ` Heiko Stuebner
2018-06-14 12:55   ` Heiko Stuebner
2018-06-19 23:21   ` Heiko Stuebner [this message]
2018-06-19 23:21     ` Heiko Stuebner
2018-06-20  5:59     ` Heinrich Schuchardt
2018-06-20  5:59       ` Heinrich Schuchardt
2018-06-20  5:59       ` Heinrich Schuchardt
2018-06-20  9:15       ` Heiko Stübner
2018-06-20  9:15         ` Heiko Stübner
2018-06-20  9:15         ` Heiko Stübner
2018-06-20 19:57         ` Heinrich Schuchardt
2018-06-20 19:57           ` Heinrich Schuchardt
2018-06-20 19:57           ` Heinrich Schuchardt
2018-06-21  0:57           ` Heinrich Schuchardt
2018-06-21  0:57             ` Heinrich Schuchardt
2018-06-21  0:57             ` Heinrich Schuchardt
2018-06-21 11:37             ` Heiko Stuebner
2018-06-21 11:37               ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10782218.jfpm9omiT7@phil \
    --to=heiko@sntech.de \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=enric.balletbo@collabora.com \
    --cc=jay.xu@rock-chips.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=phh@phh.me \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=vagrant@debian.org \
    --cc=will.deacon@arm.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.