From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Bjorn Helgaas <bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
Cc: Matthew Wilcox <willy-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>,
Marcelo Tosatti
<marcelo.tosatti-3EexvZdKGZRWk0Htik3J/w@public.gmane.org>,
willy-tRhHnHjXm5DYtjvyW6yDsg@public.gmane.org,
ACPI Developers
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: Re: fix ACPI poweroff in 2.4.25-rc2
Date: 06 Mar 2004 01:16:48 -0500 [thread overview]
Message-ID: <1078553807.12999.3187.camel@dhcppc4> (raw)
In-Reply-To: <200403031305.31966.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
On Wed, 2004-03-03 at 15:05, Bjorn Helgaas wrote:
> On Wednesday 03 March 2004 12:46 pm, Matthew Wilcox wrote:
> > On Wed, Mar 03, 2004 at 11:17:25AM -0700, Bjorn Helgaas wrote:
> Here's a patch to do it that way, if you prefer. acpi_system_save_state()
> isn't defined before use, so you get a warning about that, which I didn't
> bother to fix (I expect x86 probably sees the same warning).
I think you mean this, yes?
(note that CONFIG_X86 was redundant since CONFIG_ACPI_SLEEP depends on
it)
-Len
===== drivers/acpi/system.c 1.16 vs edited =====
--- 1.16/drivers/acpi/system.c Sun Feb 15 06:38:17 2004
+++ edited/drivers/acpi/system.c Sat Mar 6 00:57:18 2004
@@ -41,14 +41,18 @@
#include <acpi/acpi_bus.h>
#include <acpi/acpi_drivers.h>
-#ifdef CONFIG_X86
#ifdef CONFIG_ACPI_SLEEP
#include <linux/mc146818rtc.h>
#include <linux/irq.h>
#include <asm/hw_irq.h>
-#endif
-#endif
+acpi_status acpi_system_save_state(u32);
+#else
+static inline acpi_status acpi_system_save_state(u32 state)
+{
+ return AE_OK;
+}
+#endif /* !CONFIG_ACPI_SLEEP */
#define _COMPONENT ACPI_SYSTEM_COMPONENT
ACPI_MODULE_NAME ("acpi_system")
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
next prev parent reply other threads:[~2004-03-06 6:16 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-03 18:17 fix ACPI poweroff in 2.4.25-rc2 Bjorn Helgaas
[not found] ` <200403031117.25937.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2004-03-03 19:46 ` Matthew Wilcox
[not found] ` <20040303194656.GV25779-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-03-03 20:05 ` Bjorn Helgaas
[not found] ` <200403031305.31966.bjorn.helgaas-VXdhtT5mjnY@public.gmane.org>
2004-03-06 6:16 ` Len Brown [this message]
2004-03-03 20:20 ` Willy Tarreau
[not found] ` <20040303202027.GA30084-HkMpAodKYdnXX8ko2wsARw@public.gmane.org>
2004-03-06 6:21 ` Len Brown
[not found] ` <1078554086.12991.3191.camel-D2Zvc0uNKG8@public.gmane.org>
2004-03-06 8:52 ` Willy Tarreau
2004-03-06 9:16 ` Willy Tarreau
2004-03-06 11:01 ` Willy Tarreau
2004-03-08 16:34 ` Pavel Machek
[not found] ` <20040308163452.GE5352-u08AdweFZfgxtPtxi4kahqVXKuFTiq87@public.gmane.org>
2004-03-08 18:15 ` Marcelo Tosatti
[not found] ` <Pine.LNX.4.44.0403081515190.10436-100000-N7x2SXzAOustNcHCoTQCcg@public.gmane.org>
2004-03-08 18:23 ` Pavel Machek
2004-03-08 18:32 ` Pavel Machek
[not found] ` <20040308183228.GD484-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-03-08 18:39 ` Marcelo Tosatti
[not found] ` <Pine.LNX.4.44.0403081539370.13683-100000-N7x2SXzAOustNcHCoTQCcg@public.gmane.org>
2004-03-08 19:58 ` Pavel Machek
2004-03-08 20:14 ` Willy Tarreau
[not found] ` <20040308201411.GA18636-HkMpAodKYdnXX8ko2wsARw@public.gmane.org>
2004-03-08 20:54 ` Pavel Machek
[not found] ` <20040308205444.GH484-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-03-08 21:11 ` Willy Tarreau
2004-03-09 23:33 ` [PATCH] ACPI poweroff fixes for 2.4.26-pre2 Willy Tarreau
[not found] ` <20040309233325.GA22953-HkMpAodKYdnXX8ko2wsARw@public.gmane.org>
2004-03-10 11:46 ` Sérgio Monteiro Basto
2004-03-11 10:51 ` Bruno Ducrot
2004-03-14 15:51 ` Sérgio Monteiro Basto
[not found] ` <1079279490.10225.10.camel-4/PLUo9XfK8@public.gmane.org>
2004-03-15 21:07 ` Willy Tarreau
[not found] ` <20040315210729.GA19306-HkMpAodKYdnXX8ko2wsARw@public.gmane.org>
2004-03-15 22:23 ` Sérgio Monteiro Basto
[not found] ` <1079389434.3695.2.camel-4/PLUo9XfK8@public.gmane.org>
2004-03-15 23:19 ` Willy Tarreau
[not found] ` <20040315231927.GA19829-HkMpAodKYdnXX8ko2wsARw@public.gmane.org>
2004-03-22 10:59 ` Pavel Machek
[not found] ` <20040322105946.GC1505-u08AdweFZfgxtPtxi4kahqVXKuFTiq87@public.gmane.org>
2004-03-25 22:22 ` Sérgio Monteiro Basto
[not found] ` <1080253327.3755.20.camel-4/PLUo9XfK8@public.gmane.org>
2004-03-25 22:29 ` Pavel Machek
[not found] ` <20040325222934.GF2179-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-03-25 22:50 ` Sérgio Monteiro Basto
[not found] ` <1080255058.4187.1.camel-4/PLUo9XfK8@public.gmane.org>
2004-03-25 23:00 ` Pavel Machek
[not found] ` <20040325230037.GK2179-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-03-26 1:01 ` Sérgio Monteiro Basto
[not found] ` <1080262910.4144.39.camel-4/PLUo9XfK8@public.gmane.org>
2004-03-26 17:41 ` Sérgio Monteiro Basto
[not found] ` <1080322903.2325.113.camel-4/PLUo9XfK8@public.gmane.org>
2004-03-26 22:07 ` Pavel Machek
[not found] ` <20040326220723.GC9491-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2004-03-26 22:34 ` Sérgio Monteiro Basto
2004-03-27 14:01 ` Sérgio Monteiro Basto
2004-03-26 5:55 ` Willy Tarreau
[not found] ` <20040326055547.GA26599-HkMpAodKYdnXX8ko2wsARw@public.gmane.org>
2004-03-26 8:53 ` Hartwig Felger
2004-03-26 10:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1078553807.12999.3187.camel@dhcppc4 \
--to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=bjorn.helgaas-VXdhtT5mjnY@public.gmane.org \
--cc=marcelo.tosatti-3EexvZdKGZRWk0Htik3J/w@public.gmane.org \
--cc=willy-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
--cc=willy-tRhHnHjXm5DYtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.