Re: Re: fix ACPI poweroff in 2.4.25-rc2

[Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>]

Hi!

> > there's broken machine where calling acpi_system_save_state() with
> > invalid argument fixes it by accident.
> 
> In fact it does not fix it by accident, it's the previous code which
> broke it by accident. Older ACPI poweroff code has been working well
> on this machine, and suddenly stopped working. So i looked at what
> changed and noticed that the acpi_poweroff() function changed from
> _I don't remember what function_ to acpi_suspend(S5), and that
> acpi_system_save_state(), which was called implicitly in the previous
> function got lost during the change. Taking it back fixed my problem,
> but I cannot say for sure that it will not break anything else, but its
> use seems legitimate at first glance.

Can you replace

acpi_system_save_state() with

        pm_send_all(PM_SAVE_STATE, (void *)3);
        pm_send_all(PM_SUSPEND, (void *)3);

?

That should fix it, too, and does not depend on CONFIG_ACPI_SLEEP.

							Pavel
-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click