From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: stefan.doesinger-dYJrdcitkgg0+Ua9VpOLR6Q1ief8SNuKXqFh9Ls21Oc@public.gmane.org
Cc: ACPI Developers
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: PCI not restored correctly after suspend to ram
Date: 19 Mar 2004 13:10:56 -0500 [thread overview]
Message-ID: <1079719856.7278.30.camel@dhcppc4> (raw)
In-Reply-To: <200403180935.09436.stefan.doesinger-dYJrdcitkgg0+Ua9VpOLR6Q1ief8SNuKXqFh9Ls21Oc@public.gmane.org>
On Thu, 2004-03-18 at 03:35, Stefan Dösinger wrote:
...
> I can get most devices devies to work by setting the pci registers with setpci
> after resume. I use the attached fixpci.sh script to do so. I can get my
> soundcard, the ethernet card(02:02.0) and the wireless(02:04.0) to work. I
> have not tested firewire(02:07.0). The secound Cardbus bride(02:06.1) seems
> to have more problems, it's not even listed correctly.
> The file "lspci_after_suspend_fix" contains the output of lspci -vvx after
> running fixpci.sh
>
> Restoring the pci registers is a workaround, but I'd like the kernel to handle
> this so I don't have to unload and reload all modules, especially the
> soundcard driver.
>
> It this a acpi bug, a bug in the pci driver or a bug in the drivers for the
> devices?
Stefan,
Bruno is correct, the PCI config space should be saved and restored by
the driver's suspend and resume routines. suspend/resume routines
typically do other hardware dependent stuff, but your debugging suggests
that at least for some of these devices, simply saving and restoring pci
config space (pci_save_state()/pci_restore_state()) may be sufficient.
Time to take a look at the drivers for those devices...
cheers,
-Len
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
next prev parent reply other threads:[~2004-03-19 18:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-18 8:35 PCI not restored correctly after suspend to ram Stefan Dösinger
[not found] ` <200403180935.09436.stefan.doesinger-dYJrdcitkgg0+Ua9VpOLR6Q1ief8SNuKXqFh9Ls21Oc@public.gmane.org>
2004-03-19 10:59 ` Bruno Ducrot
2004-03-19 18:10 ` Len Brown [this message]
[not found] ` <1079719856.7278.30.camel-D2Zvc0uNKG8@public.gmane.org>
2004-03-21 19:28 ` Stefan Dösinger
2004-03-23 20:42 ` Stefan Dösinger
2004-03-31 16:15 ` Pavel Machek
2004-03-19 19:25 ` Len Brown
2004-03-19 20:35 ` b44 suspend/resume (Re: PCI not restored correctly after suspend to ram) Len Brown
[not found] ` <1079728500.7277.140.camel-D2Zvc0uNKG8@public.gmane.org>
2004-03-21 19:13 ` Stefan Dösinger
2004-03-22 20:27 ` Stefan Dösinger
2004-03-23 2:45 ` David S. Miller
2004-03-20 4:47 ` PCI not restored correctly after suspend to ram Len Brown
2004-03-20 5:46 ` pci bridge suspend/resume (Re: PCI not restored correctly after suspend to ram) Len Brown
[not found] ` <1079761564.7274.730.camel-D2Zvc0uNKG8@public.gmane.org>
2004-03-20 5:52 ` cardbus " Len Brown
[not found] ` <1079761951.7277.735.camel-D2Zvc0uNKG8@public.gmane.org>
2004-03-21 19:36 ` Stefan Dösinger
2004-03-20 8:28 ` pci " Jeff Garzik
[not found] ` <405C00C6.3010805-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2004-03-20 13:45 ` Matthew Wilcox
[not found] ` <20040320134542.GV25059-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-03-20 18:00 ` Grant Grundler
2004-03-20 18:10 ` Greg KH
[not found] ` <20040320181000.GA8272-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2004-03-22 22:34 ` Adam Belay
[not found] ` <20040322223425.GB3213-IBH0VoN/3vPQT0dZR+AlfA@public.gmane.org>
2004-03-23 9:23 ` Russell King
[not found] ` <20040323092338.A21352-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2004-03-23 16:07 ` Grant Grundler
2004-03-24 1:35 ` Greg KH
[not found] ` <20040324013557.GB21477-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2004-03-24 9:07 ` Russell King
[not found] ` <20040324090746.A13095-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2004-03-24 13:26 ` Matthew Wilcox
[not found] ` <20040324132632.GI25059-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-03-24 15:14 ` Russell King
2004-03-31 6:03 ` Nate Lawson
[not found] ` <20040330214941.L85074-Y6VGUYTwhu0@public.gmane.org>
2004-03-31 7:28 ` Russell King
[not found] ` <20040331082834.B27804-f404yB8NqCZvn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2004-03-31 15:28 ` Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1079719856.7278.30.camel@dhcppc4 \
--to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=stefan.doesinger-dYJrdcitkgg0+Ua9VpOLR6Q1ief8SNuKXqFh9Ls21Oc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.