All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: [PATCH] I2C update for 2.6.5
Date: Thu, 19 May 2005 06:24:52 +0000	[thread overview]
Message-ID: <10819814522824@kroah.com> (raw)
In-Reply-To: <10819814522020@kroah.com>
In-Reply-To: <10819814492866@kroah.com>

ChangeSet 1.1643.36.21, 2004/04/09 12:06:02-07:00, greg@kroah.com

[PATCH] I2C: minor bugfixes for the pcf8591.c driver and formatting cleanups.


 drivers/i2c/chips/pcf8591.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)


diff -Nru a/drivers/i2c/chips/pcf8591.c b/drivers/i2c/chips/pcf8591.c
--- a/drivers/i2c/chips/pcf8591.c	Wed Apr 14 15:13:11 2004
+++ b/drivers/i2c/chips/pcf8591.c	Wed Apr 14 15:13:11 2004
@@ -125,8 +125,7 @@
 	unsigned int value;
 	struct i2c_client *client = to_i2c_client(dev);
 	struct pcf8591_data *data = i2c_get_clientdata(client);
-	if ((value = (simple_strtoul(buf, NULL, 10) + 5) / 10) <= 255);
-	{
+	if ((value = (simple_strtoul(buf, NULL, 10) + 5) / 10) <= 255) {
 		data->aout = value;
 		i2c_smbus_write_byte_data(client, data->control, data->aout);
 	}
@@ -235,9 +234,9 @@
 	/* OK, this is not exactly good programming practice, usually. But it is
 	   very code-efficient in this case. */
 
-      exit_kfree:
+exit_kfree:
 	kfree(new_client);
-      exit:
+exit:
 	return err;
 }
 
@@ -277,8 +276,7 @@
 
 	down(&data->update_lock);
 
-	if ((data->control & PCF8591_CONTROL_AICH_MASK) != channel)
-	{
+	if ((data->control & PCF8591_CONTROL_AICH_MASK) != channel) {
 		data->control = (data->control & ~PCF8591_CONTROL_AICH_MASK)
 			      | channel;
 		i2c_smbus_write_byte(client, data->control);


WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] I2C update for 2.6.5
Date: Wed, 14 Apr 2004 15:24:12 -0700	[thread overview]
Message-ID: <10819814522824@kroah.com> (raw)
In-Reply-To: <10819814522020@kroah.com>

ChangeSet 1.1643.36.21, 2004/04/09 12:06:02-07:00, greg@kroah.com

[PATCH] I2C: minor bugfixes for the pcf8591.c driver and formatting cleanups.


 drivers/i2c/chips/pcf8591.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)


diff -Nru a/drivers/i2c/chips/pcf8591.c b/drivers/i2c/chips/pcf8591.c
--- a/drivers/i2c/chips/pcf8591.c	Wed Apr 14 15:13:11 2004
+++ b/drivers/i2c/chips/pcf8591.c	Wed Apr 14 15:13:11 2004
@@ -125,8 +125,7 @@
 	unsigned int value;
 	struct i2c_client *client = to_i2c_client(dev);
 	struct pcf8591_data *data = i2c_get_clientdata(client);
-	if ((value = (simple_strtoul(buf, NULL, 10) + 5) / 10) <= 255);
-	{
+	if ((value = (simple_strtoul(buf, NULL, 10) + 5) / 10) <= 255) {
 		data->aout = value;
 		i2c_smbus_write_byte_data(client, data->control, data->aout);
 	}
@@ -235,9 +234,9 @@
 	/* OK, this is not exactly good programming practice, usually. But it is
 	   very code-efficient in this case. */
 
-      exit_kfree:
+exit_kfree:
 	kfree(new_client);
-      exit:
+exit:
 	return err;
 }
 
@@ -277,8 +276,7 @@
 
 	down(&data->update_lock);
 
-	if ((data->control & PCF8591_CONTROL_AICH_MASK) != channel)
-	{
+	if ((data->control & PCF8591_CONTROL_AICH_MASK) != channel) {
 		data->control = (data->control & ~PCF8591_CONTROL_AICH_MASK)
 			      | channel;
 		i2c_smbus_write_byte(client, data->control);


  parent reply	other threads:[~2005-05-19  6:24 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-14 22:22 [BK PATCH] I2C update for 2.6.5 Greg KH
2005-05-19  6:24 ` Greg KH
2004-04-14 22:24 ` [PATCH] " Greg KH
2005-05-19  6:24   ` Greg KH
2004-04-14 22:24   ` Greg KH
2004-04-14 22:24     ` Greg KH
2005-05-19  6:24       ` Greg KH
2004-04-14 22:24       ` Greg KH
2005-05-19  6:24         ` Greg KH
2004-04-14 22:24         ` Greg KH
2005-05-19  6:24           ` Greg KH
2004-04-14 22:24           ` Greg KH
2005-05-19  6:24             ` Greg KH
2004-04-14 22:24             ` Greg KH
2005-05-19  6:24               ` Greg KH
2004-04-14 22:24               ` Greg KH
2005-05-19  6:24                 ` Greg KH
2004-04-14 22:24                 ` Greg KH
2005-05-19  6:24                   ` Greg KH
2004-04-14 22:24                   ` Greg KH
2005-05-19  6:24                     ` Greg KH
2004-04-14 22:24                     ` Greg KH
2005-05-19  6:24                       ` Greg KH
2004-04-14 22:24                       ` Greg KH
2005-05-19  6:24                         ` Greg KH
2004-04-14 22:24                         ` Greg KH
2005-05-19  6:24                           ` Greg KH
2004-04-14 22:24                           ` Greg KH
2004-04-14 22:24                             ` Greg KH
2005-05-19  6:24                               ` Greg KH
2004-04-14 22:24                               ` Greg KH
2004-04-14 22:24                                 ` Greg KH
2005-05-19  6:24                                   ` Greg KH
2004-04-14 22:24                                   ` Greg KH
2005-05-19  6:24                                     ` Greg KH
2004-04-14 22:24                                     ` Greg KH
2005-05-19  6:24                                       ` Greg KH
2004-04-14 22:24                                       ` Greg KH
2004-04-14 22:24                                         ` Greg KH [this message]
2005-05-19  6:24                                           ` Greg KH
2004-04-14 22:24                                           ` Greg KH
2005-05-19  6:24                                             ` Greg KH
2004-04-14 22:24                                             ` Greg KH
2005-05-19  6:24                                               ` Greg KH
2004-04-14 22:24                                               ` Greg KH
2005-05-19  6:24                                                 ` Greg KH
2004-04-14 22:24                                                 ` Greg KH
2005-05-19  6:24                                                   ` Greg KH
2004-04-14 22:24                                                   ` Greg KH
2005-05-19  6:24                                                     ` Greg KH
2004-04-14 22:24                                                     ` Greg KH
2005-05-19  6:24                                                       ` Greg KH
2004-04-14 22:24                                                       ` Greg KH
2005-05-19  6:24                                                         ` Greg KH
2004-04-14 22:24                                                         ` Greg KH
2005-05-19  6:24                                                           ` Greg KH
2004-04-14 22:24                                                           ` Greg KH
2005-05-19  6:24                                                             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10819814522824@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sensors@stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.