From: Alex Williamson <alex.williamson@hp.com>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>,
akpm@osdl.org, linux-ia64 <linux-ia64@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/3] efivars driver update and move
Date: Thu, 29 Apr 2004 22:08:15 +0000 [thread overview]
Message-ID: <1083276494.8416.114.camel@localhost> (raw)
In-Reply-To: <20040429211930.GC15106@lists.us.dell.com>
On Thu, 2004-04-29 at 15:19, Matt Domsch wrote:
> On Thu, Apr 29, 2004 at 01:50:54PM -0600, Alex Williamson wrote:
> > # stat BootOrder-8be4df61-93ca-11d2-aa0d-00e098032b8c\ /
> > File: `BootOrder-8be4df61-93ca-11d2-aa0d-00e098032b8c /'
>
> FWIW, my Intel Tiger2-based system doesn't have the space at the end...
>
> > *(short_name + strlen(short_name)) = '-';
> > efi_guid_unparse(vendor_guid, short_name + strlen(short_name));
> > *(short_name + strlen(short_name)) = ' ';
>
> even though looking at this I would have expected it to...
Yeah, I'm not sure how you couldn't have a space at the end...
>
> Can you remove that last line and see what it does? Best as I can
> tell, it isn't necessary or desired.
Yes, removing that last line above gets rid of the space, everything
looks right, and efibootmgr doesn't complain. I'd attach a patch but
I'm curious if Matt T. had some reason for adding it.
Alex
--
Alex Williamson HP Linux & Open Source Lab
WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@hp.com>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: "Tolentino, Matthew E" <matthew.e.tolentino@intel.com>,
akpm@osdl.org, linux-ia64 <linux-ia64@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch 1/3] efivars driver update and move
Date: Thu, 29 Apr 2004 16:08:15 -0600 [thread overview]
Message-ID: <1083276494.8416.114.camel@localhost> (raw)
In-Reply-To: <20040429211930.GC15106@lists.us.dell.com>
On Thu, 2004-04-29 at 15:19, Matt Domsch wrote:
> On Thu, Apr 29, 2004 at 01:50:54PM -0600, Alex Williamson wrote:
> > # stat BootOrder-8be4df61-93ca-11d2-aa0d-00e098032b8c\ /
> > File: `BootOrder-8be4df61-93ca-11d2-aa0d-00e098032b8c /'
>
> FWIW, my Intel Tiger2-based system doesn't have the space at the end...
>
> > *(short_name + strlen(short_name)) = '-';
> > efi_guid_unparse(vendor_guid, short_name + strlen(short_name));
> > *(short_name + strlen(short_name)) = ' ';
>
> even though looking at this I would have expected it to...
Yeah, I'm not sure how you couldn't have a space at the end...
>
> Can you remove that last line and see what it does? Best as I can
> tell, it isn't necessary or desired.
Yes, removing that last line above gets rid of the space, everything
looks right, and efibootmgr doesn't complain. I'd attach a patch but
I'm curious if Matt T. had some reason for adding it.
Alex
--
Alex Williamson HP Linux & Open Source Lab
next prev parent reply other threads:[~2004-04-29 22:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-22 15:51 [patch 1/3] efivars driver update and move Matt Tolentino
2004-04-22 17:32 ` Matt Tolentino
2004-04-22 16:46 ` Bjorn Helgaas
2004-04-22 16:46 ` Bjorn Helgaas
2004-04-22 17:14 ` Tolentino, Matthew E
2004-04-22 17:14 ` Tolentino, Matthew E
2004-04-22 17:20 ` Bjorn Helgaas
2004-04-22 17:20 ` Bjorn Helgaas
2004-04-29 19:50 ` Alex Williamson
2004-04-29 19:50 ` Alex Williamson
2004-04-29 21:19 ` Matt Domsch
2004-04-29 21:19 ` Matt Domsch
2004-04-29 22:08 ` Alex Williamson [this message]
2004-04-29 22:08 ` Alex Williamson
2004-04-23 22:29 ` Matt Domsch
2004-04-23 22:29 ` Matt Domsch
2004-04-24 3:41 ` Matt Domsch
2004-04-24 3:41 ` Matt Domsch
2004-04-26 18:57 ` Matt Domsch
2004-04-26 18:57 ` Matt Domsch
2004-04-26 19:30 ` Matt Tolentino
2004-04-26 21:15 ` Matt Tolentino
2004-04-30 0:09 ` Matt Tolentino
2004-04-30 1:55 ` Matt Tolentino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1083276494.8416.114.camel@localhost \
--to=alex.williamson@hp.com \
--cc=Matt_Domsch@dell.com \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.e.tolentino@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.