[Bridge] [1/11] bridge - handle delete of multiple devices with same address

[Bridge] [1/11] bridge - handle delete of multiple devices with same address

[Stephen Hemminger]

This fixes the issue discovered when removing bluetooth devices from a bridge.
Need to add special case code when forwarding table is being cleaned up to 
handle the case where several devices share the same hardware address.

(Could fix on 2.4 if there is demand for it)
 
diff -Nru a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
--- a/net/bridge/br_fdb.c	2004-05-20 08:43:46 -07:00
+++ b/net/bridge/br_fdb.c	2004-05-20 08:43:46 -07:00
@@ -157,9 +157,28 @@
 		hlist_for_each_safe(h, g, &br->hash[i]) {
 			struct net_bridge_fdb_entry *f
 				= hlist_entry(h, struct net_bridge_fdb_entry, hlist);
-			if (f->dst == p) {
-				fdb_delete(f);
+			if (f->dst != p) 
+				continue;
+
+			/*
+			 * if multiple ports all have the same device address
+			 * then when one port is deleted, assign
+			 * the local entry to other port
+			 */
+			if (f->is_local) {
+				struct net_bridge_port *op;
+				list_for_each_entry(op, &br->port_list, list) {
+					if (op != p && 
+					    !memcmp(op->dev->dev_addr,
+						    f->addr.addr, ETH_ALEN)) {
+						f->dst = op;
+						goto skip_delete;
+					}
+				}
 			}
+
+			fdb_delete(f);
+		skip_delete: ;
 		}
 	}
 	write_unlock_bh(&br->hash_lock);

[1/11] bridge - handle delete of multiple devices with same address

[Stephen Hemminger]

This fixes the issue discovered when removing bluetooth devices from a bridge.
Need to add special case code when forwarding table is being cleaned up to 
handle the case where several devices share the same hardware address.

(Could fix on 2.4 if there is demand for it)
 
diff -Nru a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
--- a/net/bridge/br_fdb.c	2004-05-20 08:43:46 -07:00
+++ b/net/bridge/br_fdb.c	2004-05-20 08:43:46 -07:00
@@ -157,9 +157,28 @@
 		hlist_for_each_safe(h, g, &br->hash[i]) {
 			struct net_bridge_fdb_entry *f
 				= hlist_entry(h, struct net_bridge_fdb_entry, hlist);
-			if (f->dst == p) {
-				fdb_delete(f);
+			if (f->dst != p) 
+				continue;
+
+			/*
+			 * if multiple ports all have the same device address
+			 * then when one port is deleted, assign
+			 * the local entry to other port
+			 */
+			if (f->is_local) {
+				struct net_bridge_port *op;
+				list_for_each_entry(op, &br->port_list, list) {
+					if (op != p && 
+					    !memcmp(op->dev->dev_addr,
+						    f->addr.addr, ETH_ALEN)) {
+						f->dst = op;
+						goto skip_delete;
+					}
+				}
 			}
+
+			fdb_delete(f);
+		skip_delete: ;
 		}
 	}
 	write_unlock_bh(&br->hash_lock);

[Bridge] Re: [1/11] bridge - handle delete of multiple devices with same address

[Diego Liziero]

Great work Stephen, just tested with Bluetooth PAN
and everything works now.

For the bluetooth people, here is the bk link to the patch:
http://linux.bkbits.net:8080/linux-2.5/cset@40afb9c8_3WOgNFCBlahWsksS_5icQ?nav=index.html|ChangeSet@-3d

Thanks to all the people that helped me.
Regards,
Diego.

On Sat, 2004-05-22 at 00:45, Stephen Hemminger wrote:
> This fixes the issue discovered when removing bluetooth devices from a bridge.
> Need to add special case code when forwarding table is being cleaned up to 
> handle the case where several devices share the same hardware address.
> 
> (Could fix on 2.4 if there is demand for it)
>  
> diff -Nru a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> --- a/net/bridge/br_fdb.c	2004-05-20 08:43:46 -07:00
> +++ b/net/bridge/br_fdb.c	2004-05-20 08:43:46 -07:00
> @@ -157,9 +157,28 @@
>  		hlist_for_each_safe(h, g, &br->hash[i]) {
>  			struct net_bridge_fdb_entry *f
>  				= hlist_entry(h, struct net_bridge_fdb_entry, hlist);
> -			if (f->dst == p) {
> -				fdb_delete(f);
> +			if (f->dst != p) 
> +				continue;
> +
> +			/*
> +			 * if multiple ports all have the same device address
> +			 * then when one port is deleted, assign
> +			 * the local entry to other port
> +			 */
> +			if (f->is_local) {
> +				struct net_bridge_port *op;
> +				list_for_each_entry(op, &br->port_list, list) {
> +					if (op != p && 
> +					    !memcmp(op->dev->dev_addr,
> +						    f->addr.addr, ETH_ALEN)) {
> +						f->dst = op;
> +						goto skip_delete;
> +					}
> +				}
>  			}
> +
> +			fdb_delete(f);
> +		skip_delete: ;
>  		}
>  	}
>  	write_unlock_bh(&br->hash_lock);

[Bluez-devel] Re: [1/11] bridge - handle delete of multiple devices with same address

[Diego Liziero]

Great work Stephen, just tested with Bluetooth PAN
and everything works now.

For the bluetooth people, here is the bk link to the patch:
http://linux.bkbits.net:8080/linux-2.5/cset@40afb9c8_3WOgNFCBlahWsksS_5icQ?nav=index.html|ChangeSet@-3d

Thanks to all the people that helped me.
Regards,
Diego.

On Sat, 2004-05-22 at 00:45, Stephen Hemminger wrote:
> This fixes the issue discovered when removing bluetooth devices from a bridge.
> Need to add special case code when forwarding table is being cleaned up to 
> handle the case where several devices share the same hardware address.
> 
> (Could fix on 2.4 if there is demand for it)
>  
> diff -Nru a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> --- a/net/bridge/br_fdb.c	2004-05-20 08:43:46 -07:00
> +++ b/net/bridge/br_fdb.c	2004-05-20 08:43:46 -07:00
> @@ -157,9 +157,28 @@
>  		hlist_for_each_safe(h, g, &br->hash[i]) {
>  			struct net_bridge_fdb_entry *f
>  				= hlist_entry(h, struct net_bridge_fdb_entry, hlist);
> -			if (f->dst == p) {
> -				fdb_delete(f);
> +			if (f->dst != p) 
> +				continue;
> +
> +			/*
> +			 * if multiple ports all have the same device address
> +			 * then when one port is deleted, assign
> +			 * the local entry to other port
> +			 */
> +			if (f->is_local) {
> +				struct net_bridge_port *op;
> +				list_for_each_entry(op, &br->port_list, list) {
> +					if (op != p && 
> +					    !memcmp(op->dev->dev_addr,
> +						    f->addr.addr, ETH_ALEN)) {
> +						f->dst = op;
> +						goto skip_delete;
> +					}
> +				}
>  			}
> +
> +			fdb_delete(f);
> +		skip_delete: ;
>  		}
>  	}
>  	write_unlock_bh(&br->hash_lock);



-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

[Bluez-devel] Bluetooth, Mobile IPv6 and PAN profile

[Wang Haiguang]

Hi, all.

Has anybody tried to test the Mobile IPv6 over bluetooth with PAN profile?

For example, two node work as NAP with bluetooth and one node as PANU.

If you did, please give me some hint?

Now I am trying on the stuffs. 

Thanks a lot.

Best regards.

Haiguang


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Bluetooth, Mobile IPv6 and PAN profile

[Marcel Holtmann]

Hi Haiguang,

> Has anybody tried to test the Mobile IPv6 over bluetooth with PAN profile?
> 
> For example, two node work as NAP with bluetooth and one node as PANU.
> 
> If you did, please give me some hint?
> 
> Now I am trying on the stuffs. 

I've never done this nor have I tested IPv6 together with PAN, but the
BNEP is only an ethernet emulation and so everything that's working over
ethernet should work over BNEP, too.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] Bluetooth, Mobile IPv6 and PAN profile

[David Woodhouse]

On Mon, 2004-05-24 at 16:00 +0200, Marcel Holtmann wrote:
> I've never done this nor have I tested IPv6 together with PAN, but the
> BNEP is only an ethernet emulation and so everything that's working over
> ethernet should work over BNEP, too.

IPv6 over PAN works fine for me. If you're using radvd on the access
point and you are adding each bnep%d connection to a bridge, then make
sure you poke radvd each time a device is added. When radvd starts up
there are no devices on the bridge so it seems to have MAC address
00:00:00:00:00:00. 

cf. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=103469
and https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104421

This is all working in Fedora Core 2.

-- 
dwmw2

RE: [Bluez-devel] Bluetooth, Mobile IPv6 and PAN profile

[Wang Haiguang]

Thanks.

That helps greatly.

Best regards.

Haiguang

-----Original Message-----
From: David Woodhouse [mailto:dwmw2@infradead.org]
Sent: 2004年5月25日 16:30
To: Marcel Holtmann
Cc: Wang Haiguang; BlueZ Mailing List
Subject: Re: [Bluez-devel] Bluetooth, Mobile IPv6 and PAN profile


On Mon, 2004-05-24 at 16:00 +0200, Marcel Holtmann wrote:
> I've never done this nor have I tested IPv6 together with PAN, but the
> BNEP is only an ethernet emulation and so everything that's working over
> ethernet should work over BNEP, too.

IPv6 over PAN works fine for me. If you're using radvd on the access
point and you are adding each bnep%d connection to a bridge, then make
sure you poke radvd each time a device is added. When radvd starts up
there are no devices on the bridge so it seems to have MAC address
00:00:00:00:00:00.

cf. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=103469
and https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104421

This is all working in Fedora Core 2.

--
dwmw2

[Bluez-devel] Some question on flush timeout at L2CAP.

[Wang Haiguang]

Hi, all.

I saw there is a parameter for the flush timeout in L2CAP. 

It is defiened in the ..../include/net/bluetooth/l2cap.h as follows:

#define L2CAP_DEFAULT_FLUSH_TO 0xFFFF

and in the l2cap.c line 323 the value is assigned to some socket
variable as follows:

pi->flush_to = L2CAP_DEFAULT_FLUSH_TO.

What is the function of this variable "flush_to"?

Is it used to flush the L2CAP Packet after timeout? Where is this
value used?

I searched through the source code and find no timer related to it. 

And also, does anybody knows what are the value of the 
"flush timeout" value of the baseband and can it be configured through
hciconfig command?

Thanks.

Haiguang


-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel