From: greg@kroah.com (Greg KH)
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: [PATCH] I2C update for 2.6.7-rc1
Date: Thu, 19 May 2005 06:25:00 +0000 [thread overview]
Message-ID: <10857816431296@kroah.com> (raw)
In-Reply-To: <10857816431154@kroah.com>
In-Reply-To: <1085781643100@kroah.com>
ChangeSet 1.1717.6.28, 2004/05/19 00:26:34-07:00, ebs@ebshome.net
[PATCH] I2C PPC4xx IIC driver: 0-length transaction temporary fix
this patch adds temporary fix for 0-length requests (e.g. SMBUS_QUICK) to PPC4xx
IIC driver. This i2c controller doesn't support such transactions and this patch
just restores previous driver version behavior making SMBUS_QUICK-based bus scan
at least partially usable. This is temporary kludge until correct bit-banging
emulation is implemented.
drivers/i2c/busses/i2c-ibm_iic.c | 10 ++++++++++
1 files changed, 10 insertions(+)
diff -Nru a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
--- a/drivers/i2c/busses/i2c-ibm_iic.c Fri May 28 14:52:12 2004
+++ b/drivers/i2c/busses/i2c-ibm_iic.c Fri May 28 14:52:12 2004
@@ -455,6 +455,16 @@
}
for (i = 0; i < num; ++i){
if (unlikely(msgs[i].len <= 0)){
+ if (num = 1 && !msgs[0].len){
+ /* Special case for I2C_SMBUS_QUICK emulation.
+ * Although this logic is FAR FROM PERFECT, this
+ * is what previous driver version did.
+ * IBM IIC doesn't support 0-length transactions
+ * (except bit-banging through IICx_DIRECTCNTL).
+ */
+ DBG("%d: zero-length msg kludge\n", dev->idx);
+ return 0;
+ }
DBG("%d: invalid len %d in msg[%d]\n", dev->idx,
msgs[i].len, i);
return -EINVAL;
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com
Subject: Re: [PATCH] I2C update for 2.6.7-rc1
Date: Fri, 28 May 2004 15:00:43 -0700 [thread overview]
Message-ID: <10857816431296@kroah.com> (raw)
In-Reply-To: <10857816431154@kroah.com>
ChangeSet 1.1717.6.28, 2004/05/19 00:26:34-07:00, ebs@ebshome.net
[PATCH] I2C PPC4xx IIC driver: 0-length transaction temporary fix
this patch adds temporary fix for 0-length requests (e.g. SMBUS_QUICK) to PPC4xx
IIC driver. This i2c controller doesn't support such transactions and this patch
just restores previous driver version behavior making SMBUS_QUICK-based bus scan
at least partially usable. This is temporary kludge until correct bit-banging
emulation is implemented.
drivers/i2c/busses/i2c-ibm_iic.c | 10 ++++++++++
1 files changed, 10 insertions(+)
diff -Nru a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
--- a/drivers/i2c/busses/i2c-ibm_iic.c Fri May 28 14:52:12 2004
+++ b/drivers/i2c/busses/i2c-ibm_iic.c Fri May 28 14:52:12 2004
@@ -455,6 +455,16 @@
}
for (i = 0; i < num; ++i){
if (unlikely(msgs[i].len <= 0)){
+ if (num == 1 && !msgs[0].len){
+ /* Special case for I2C_SMBUS_QUICK emulation.
+ * Although this logic is FAR FROM PERFECT, this
+ * is what previous driver version did.
+ * IBM IIC doesn't support 0-length transactions
+ * (except bit-banging through IICx_DIRECTCNTL).
+ */
+ DBG("%d: zero-length msg kludge\n", dev->idx);
+ return 0;
+ }
DBG("%d: invalid len %d in msg[%d]\n", dev->idx,
msgs[i].len, i);
return -EINVAL;
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-28 21:59 [BK PATCH] I2C update for 2.6.7-rc1 Greg KH
2005-05-19 6:25 ` Greg KH
2004-05-28 22:00 ` [PATCH] " Greg KH
2005-05-19 6:25 ` Greg KH
2004-05-28 22:00 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-05-28 22:00 ` Greg KH
2004-05-28 22:00 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-05-28 22:00 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-05-28 22:00 ` Greg KH [this message]
2005-05-19 6:25 ` Greg KH
2004-05-28 22:00 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-05-28 22:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10857816431296@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.