From: Alex Williamson <alex.williamson@hp.com>
To: "David S. Miller" <davem@redhat.com>
Cc: clameter@sgi.com, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: Unaligned accesses in net/ipv4/netfilter/arp_tables.c:184
Date: Wed, 09 Jun 2004 20:29:36 +0000 [thread overview]
Message-ID: <1086812976.4288.50.camel@tdi> (raw)
In-Reply-To: <20040609130001.37a88da1.davem@redhat.com>
On Wed, 2004-06-09 at 14:00, David S. Miller wrote:
> On Wed, 09 Jun 2004 12:27:56 -0600
> Alex Williamson <alex.williamson@hp.com> wrote:
>
> > http://marc.theaimsgroup.com/?l=netfilter-devel&m\x107814727803971&w=2
>
> How can you legitimately change this structure? It's an exported
> userland interface, if you change it all the applications will
> stop working.
>
Which is probably why the patch never went anywhere. There's
certainly an alignment issue in the usage of the struct arpt_arp in the
code snippet Christoph pointed out. Sounds like it'd be better to fix
the usage than the structure alignment.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@hp.com>
To: "David S. Miller" <davem@redhat.com>
Cc: clameter@sgi.com, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: Unaligned accesses in net/ipv4/netfilter/arp_tables.c:184
Date: Wed, 09 Jun 2004 14:29:36 -0600 [thread overview]
Message-ID: <1086812976.4288.50.camel@tdi> (raw)
In-Reply-To: <20040609130001.37a88da1.davem@redhat.com>
On Wed, 2004-06-09 at 14:00, David S. Miller wrote:
> On Wed, 09 Jun 2004 12:27:56 -0600
> Alex Williamson <alex.williamson@hp.com> wrote:
>
> > http://marc.theaimsgroup.com/?l=netfilter-devel&m=107814727803971&w=2
>
> How can you legitimately change this structure? It's an exported
> userland interface, if you change it all the applications will
> stop working.
>
Which is probably why the patch never went anywhere. There's
certainly an alignment issue in the usage of the struct arpt_arp in the
code snippet Christoph pointed out. Sounds like it'd be better to fix
the usage than the structure alignment.
Alex
next prev parent reply other threads:[~2004-06-09 20:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 18:09 Unaligned accesses in net/ipv4/netfilter/arp_tables.c:184 Christoph Lameter
2004-06-09 18:09 ` Christoph Lameter
2004-06-09 18:27 ` Alex Williamson
2004-06-09 18:27 ` Alex Williamson
2004-06-09 20:00 ` David S. Miller
2004-06-09 20:00 ` David S. Miller
2004-06-09 20:29 ` Alex Williamson [this message]
2004-06-09 20:29 ` Alex Williamson
2004-06-09 20:29 ` David S. Miller
2004-06-09 20:29 ` David S. Miller
2004-06-09 21:33 ` Harald Welte
2004-06-09 21:33 ` Harald Welte
2004-06-09 21:52 ` Alex Williamson
2004-06-09 21:52 ` Alex Williamson
2004-06-10 1:45 ` Chris Wedgwood
2004-06-10 1:45 ` Chris Wedgwood
2004-06-10 5:46 ` Harald Welte
2004-06-10 5:46 ` Harald Welte
2004-06-11 5:04 ` David S. Miller
2004-06-11 5:04 ` David S. Miller
2004-06-11 5:41 ` Andreas Dilger
2004-06-11 5:41 ` Andreas Dilger
2004-06-11 5:40 ` David S. Miller
2004-06-11 5:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086812976.4288.50.camel@tdi \
--to=alex.williamson@hp.com \
--cc=clameter@sgi.com \
--cc=davem@redhat.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.