From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: John Steele Scott <toojays@toojays.net>
Cc: linuxppc-dev list <linuxppc-dev@lists.linuxppc.org>,
Christiaan Welvaart <cjw@daneel.dyndns.org>,
cpufreq@www.linux.org.uk
Subject: Re: [PATCH] cpufreq support for 7447A on 2004 iBooks
Date: Thu, 10 Jun 2004 11:12:07 -0500 [thread overview]
Message-ID: <1086883926.2977.145.camel@gaston> (raw)
In-Reply-To: <200406102105.27654.toojays@toojays.net>
> I have made a new patch for this, available from:
> http://www.toojays.net/~toojays/misc/7447a_cpufreq_20040610.patch
Looks good except for some coding style issues ;)
Use spaces between } and else for example, there's also an if without a
space before the ( and please, name the low level asm function low_* like
the other ones, for consistency.
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: John Steele Scott <toojays@toojays.net>
Cc: linuxppc-dev list <linuxppc-dev@lists.linuxppc.org>,
Christiaan Welvaart <cjw@daneel.dyndns.org>,
cpufreq@www.linux.org.uk
Subject: Re: [PATCH] cpufreq support for 7447A on 2004 iBooks
Date: Thu, 10 Jun 2004 11:12:07 -0500 [thread overview]
Message-ID: <1086883926.2977.145.camel@gaston> (raw)
In-Reply-To: <200406102105.27654.toojays@toojays.net>
> I have made a new patch for this, available from:
> http://www.toojays.net/~toojays/misc/7447a_cpufreq_20040610.patch
Looks good except for some coding style issues ;)
Use spaces between } and else for example, there's also an if without a
space before the ( and please, name the low level asm function low_* like
the other ones, for consistency.
Ben.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-06-10 16:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-05 9:15 [PATCH] cpufreq support for 7447A on 2004 iBooks John Steele Scott
2004-06-05 9:15 ` John Steele Scott
2004-06-05 12:53 ` John Steele Scott
2004-06-05 12:53 ` John Steele Scott
2004-06-05 16:21 ` Benjamin Herrenschmidt
2004-06-05 16:21 ` Benjamin Herrenschmidt
2004-06-10 11:34 ` John Steele Scott
2004-06-10 11:34 ` John Steele Scott
2004-06-10 16:12 ` Benjamin Herrenschmidt [this message]
2004-06-10 16:12 ` Benjamin Herrenschmidt
2004-06-16 2:34 ` John Steele Scott
2004-06-16 2:34 ` John Steele Scott
2004-06-18 12:02 ` Sebastian Henschel
2004-06-18 15:30 ` Benjamin Herrenschmidt
2004-06-19 3:19 ` John Steele Scott
2004-06-19 4:39 ` Benjamin Herrenschmidt
2004-06-20 11:13 ` John Steele Scott
2004-06-20 16:34 ` Benjamin Herrenschmidt
2004-06-30 13:14 ` Christiaan Welvaart
2004-06-10 8:50 ` Colin LEROY
2004-06-10 8:50 ` Colin LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086883926.2977.145.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=cjw@daneel.dyndns.org \
--cc=cpufreq@www.linux.org.uk \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=toojays@toojays.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.