From: Chris Mason <mason@suse.com>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] __bd_forget should wait for inodes using the mapping
Date: Fri, 18 Jun 2004 11:41:43 -0400 [thread overview]
Message-ID: <1087573303.8002.172.camel@watt.suse.com> (raw)
In-Reply-To: <20040618151558.GX12308@parcelfarce.linux.theplanet.co.uk>
On Fri, 2004-06-18 at 11:15, viro@parcelfarce.linux.theplanet.co.uk
wrote:
> On Fri, Jun 18, 2004 at 10:47:11AM -0400, Chris Mason wrote:
> > During writeback, we need to answer the question: "are there dirty pages
> > attached to this inode", and the only way to answer it is via the
> > address space.
> >
> > If bdev inodes don't want other inodes using their address space, they
> > shouldn't be setting the i_mapping on other inodes. Since they are, the
> > bdev code needs to be aware that someone else might be using it.
>
> Scheduled for 2.7.1; for now users of ->i_mapping (the fewer of them remain,
> the better) have to be aware of bdev.
>
> And yes, ->i_mapping flips on "normal" bdev inodes will go away - we set
> ->f_mapping on open directly.
Fair enough, I'll cook up some code to bump the inode->bdev->bd_inode
i_count in __sync_single_inode It won't be pretty either though, I'll
have to drop the inode_lock so that some function can take the bdev_lock
to safely use inode->i_bdev.
-chris
next prev parent reply other threads:[~2004-06-18 15:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-18 1:54 [PATCH RFC] __bd_forget should wait for inodes using the mapping Chris Mason
2004-06-18 2:01 ` Chris Mason
2004-06-18 2:10 ` viro
2004-06-18 13:03 ` Chris Mason
2004-06-18 14:22 ` viro
2004-06-18 14:47 ` Chris Mason
2004-06-18 15:15 ` viro
2004-06-18 15:41 ` Chris Mason [this message]
2004-06-18 15:43 ` viro
2004-06-18 16:05 ` Chris Mason
2004-06-18 20:26 ` Andrew Morton
2004-06-18 20:44 ` Chris Mason
2004-06-18 21:27 ` Andrew Morton
2004-06-18 23:15 ` Chris Mason
2004-06-18 23:25 ` Andrew Morton
2004-06-18 14:20 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087573303.8002.172.camel@watt.suse.com \
--to=mason@suse.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.