From: Chris Mason <mason@suse.com>
To: Andrew Morton <akpm@osdl.org>
Cc: viro@parcelfarce.linux.theplanet.co.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] __bd_forget should wait for inodes using the mapping
Date: Fri, 18 Jun 2004 19:15:17 -0400 [thread overview]
Message-ID: <1087600516.1512.26.camel@watt.suse.com> (raw)
In-Reply-To: <20040618142710.5d467d1b.akpm@osdl.org>
On Fri, 2004-06-18 at 17:27, Andrew Morton wrote:
> Chris Mason <mason@suse.com> wrote:
> >
> > [ skip writing block-special inodes ]
> >
> > Hmmm, any risk in missing data integrity syncs because of this?
>
> Need to think about that. sys_fsync(), sys_fdatasync() and sys_msync() go
> direct to file->f_mapping and sys_sync() will sync the blockdev via its
> kernel-internal inode. What does that leave?
I was worried about O_SYNC, That actually looks safe though,
generic_osync_inode will first write the mapping via filemap_fdatawrite
(the mapping comes from f_mapping).
It doesn't really give me warm fuzzies, but looks safe enough. Al had a
slightly different plan, maybe with your patch we can push his larger
changes off a bit?
-chris
next prev parent reply other threads:[~2004-06-18 23:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-18 1:54 [PATCH RFC] __bd_forget should wait for inodes using the mapping Chris Mason
2004-06-18 2:01 ` Chris Mason
2004-06-18 2:10 ` viro
2004-06-18 13:03 ` Chris Mason
2004-06-18 14:22 ` viro
2004-06-18 14:47 ` Chris Mason
2004-06-18 15:15 ` viro
2004-06-18 15:41 ` Chris Mason
2004-06-18 15:43 ` viro
2004-06-18 16:05 ` Chris Mason
2004-06-18 20:26 ` Andrew Morton
2004-06-18 20:44 ` Chris Mason
2004-06-18 21:27 ` Andrew Morton
2004-06-18 23:15 ` Chris Mason [this message]
2004-06-18 23:25 ` Andrew Morton
2004-06-18 14:20 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087600516.1512.26.camel@watt.suse.com \
--to=mason@suse.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.