* Re: [PATCH] prism54 use set_pci_mwi()
[not found] <200407011909.i61J90GF006580@hera.kernel.org>
@ 2004-07-05 8:26 ` Arjan van de Ven
0 siblings, 0 replies; 2+ messages in thread
From: Arjan van de Ven @ 2004-07-05 8:26 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: margitsw
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
> diff -Nru a/drivers/net/wireless/prism54/islpci_hotplug.c b/drivers/net/wireless/prism54/islpci_hotplug.c
> --- a/drivers/net/wireless/prism54/islpci_hotplug.c 2004-07-01 12:09:09 -07:00
> +++ b/drivers/net/wireless/prism54/islpci_hotplug.c 2004-07-01 12:09:09 -07:00
> @@ -321,6 +321,9 @@
> DEBUG(SHOW_TRACING, "%s: pci_set_master(pdev)\n", DRV_NAME);
> pci_set_master(pdev);
>
> + /* enable MWI */
> + pci_set_mwi(pdev);
> +
pci_set_mwi() has a return value that you're supposed to check.....
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] prism54 use set_pci_mwi()
@ 2004-07-05 9:32 Margit Schubert-While
0 siblings, 0 replies; 2+ messages in thread
From: Margit Schubert-While @ 2004-07-05 9:32 UTC (permalink / raw)
To: linux-kernel
Arjan van de Ven scribeth :
> pci_set_mwi() has a return value that you're supposed to check.....
Don't need to. Either it doesn't support MWI or the device will not
accept the new cache line size. In either case nothing changes and
as far as the driver is concerned this is not an error.
(Incidentally neither do the e1000, starfire, tulip,typhoon drivers)
Margit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-05 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200407011909.i61J90GF006580@hera.kernel.org>
2004-07-05 8:26 ` [PATCH] prism54 use set_pci_mwi() Arjan van de Ven
2004-07-05 9:32 Margit Schubert-While
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.