All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <len.brown@intel.com>
To: Zwane Mwaikambo <zwane@fsmlabs.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Shaohua Li <shaohua.li@intel.com>, Yi Zhu <yi.zhu@intel.com>,
	Andrew Morton <akpm@osdl.org>,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: Re: [PATCH][2.4/2.6] Quiesce after changing ACPI idle thread
Date: 29 Jul 2004 23:38:07 -0400	[thread overview]
Message-ID: <1091158687.9636.21.camel@dhcppc4> (raw)
In-Reply-To: <Pine.LNX.4.58.0407221123480.19190@montezuma.fsmlabs.com>

applied to 2.6.

thanks Zwane.
-Len

On Thu, 2004-07-22 at 11:30, Zwane Mwaikambo wrote:
> (Please apply this patch instead of the previously posted one).
> 
> This patch addresses the following bugzilla bug;
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=1716
> 
> When unloading the processor module we modify the currently used idle
> thread (pm_idle), this causes an oops due to the idle thread text
> being
> unloaded. This should apply to both 2.6 and 2.4.
> 
> Signed-off-by: Zwane Mwaikambo <zwane@fsmlabs.com>
> 
> Index: linux-2.6.8-rc1-mm1/drivers/acpi/processor.c
> ===================================================================
> RCS file: /home/cvsroot/linux-2.6.8-rc1-mm1/drivers/acpi/processor.c,v
> retrieving revision 1.1.1.1
> diff -u -p -B -r1.1.1.1 processor.c
> --- linux-2.6.8-rc1-mm1/drivers/acpi/processor.c        14 Jul 2004
> 04:56:25 -0000      1.1.1.1
> +++ linux-2.6.8-rc1-mm1/drivers/acpi/processor.c        20 Jul 2004
> 15:31:46 -0000
> @@ -2372,8 +2372,10 @@ acpi_processor_remove (
>         pr = (struct acpi_processor *) acpi_driver_data(device);
> 
>         /* Unregister the idle handler when processor #0 is removed.
> */
> -       if (pr->id == 0)
> +       if (pr->id == 0) {
>                 pm_idle = pm_idle_save;
> +               synchronize_kernel();
> +       }
> 
>         status = acpi_remove_notify_handler(pr->handle,
> ACPI_DEVICE_NOTIFY,
>                 acpi_processor_notify);
> 


      parent reply	other threads:[~2004-07-30  3:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-22 15:16 [PATCH][2.6] Quiesce after changing ACPI idle thread Zwane Mwaikambo
2004-07-22 15:30 ` [PATCH][2.4/2.6] " Zwane Mwaikambo
2004-07-23  2:09   ` Zwane Mwaikambo
2004-07-27  9:33     ` Zwane Mwaikambo
2004-07-30  3:38   ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1091158687.9636.21.camel@dhcppc4 \
    --to=len.brown@intel.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=shaohua.li@intel.com \
    --cc=yi.zhu@intel.com \
    --cc=zwane@fsmlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.