* [PATCH][2.6] Quiesce after changing ACPI idle thread
@ 2004-07-22 15:16 Zwane Mwaikambo
2004-07-22 15:30 ` [PATCH][2.4/2.6] " Zwane Mwaikambo
0 siblings, 1 reply; 5+ messages in thread
From: Zwane Mwaikambo @ 2004-07-22 15:16 UTC (permalink / raw)
To: Linux Kernel; +Cc: Len Brown, shaohua.li, Andrew Morton
This patch addresses the following bugzilla bug;
http://bugzilla.kernel.org/show_bug.cgi?id=1716
When unloading the processor module we modify the currently used idle
thread (pm_idle), this causes an oops due to the idle thread text being
unloaded.
Index: linux-2.6.8-rc1-mm1/drivers/acpi/processor.c
===================================================================
RCS file: /home/cvsroot/linux-2.6.8-rc1-mm1/drivers/acpi/processor.c,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 processor.c
--- linux-2.6.8-rc1-mm1/drivers/acpi/processor.c 14 Jul 2004 04:56:25 -0000 1.1.1.1
+++ linux-2.6.8-rc1-mm1/drivers/acpi/processor.c 20 Jul 2004 15:31:46 -0000
@@ -2372,8 +2372,10 @@ acpi_processor_remove (
pr = (struct acpi_processor *) acpi_driver_data(device);
/* Unregister the idle handler when processor #0 is removed. */
- if (pr->id == 0)
+ if (pr->id == 0) {
pm_idle = pm_idle_save;
+ synchronize_kernel();
+ }
status = acpi_remove_notify_handler(pr->handle, ACPI_DEVICE_NOTIFY,
acpi_processor_notify);
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH][2.4/2.6] Quiesce after changing ACPI idle thread
2004-07-22 15:16 [PATCH][2.6] Quiesce after changing ACPI idle thread Zwane Mwaikambo
@ 2004-07-22 15:30 ` Zwane Mwaikambo
2004-07-23 2:09 ` Zwane Mwaikambo
2004-07-30 3:38 ` Len Brown
0 siblings, 2 replies; 5+ messages in thread
From: Zwane Mwaikambo @ 2004-07-22 15:30 UTC (permalink / raw)
To: Linux Kernel
Cc: Len Brown, shaohua.li, yi.zhu, Andrew Morton, Marcelo Tosatti
(Please apply this patch instead of the previously posted one).
This patch addresses the following bugzilla bug;
http://bugzilla.kernel.org/show_bug.cgi?id=1716
When unloading the processor module we modify the currently used idle
thread (pm_idle), this causes an oops due to the idle thread text being
unloaded. This should apply to both 2.6 and 2.4.
Signed-off-by: Zwane Mwaikambo <zwane@fsmlabs.com>
Index: linux-2.6.8-rc1-mm1/drivers/acpi/processor.c
===================================================================
RCS file: /home/cvsroot/linux-2.6.8-rc1-mm1/drivers/acpi/processor.c,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 processor.c
--- linux-2.6.8-rc1-mm1/drivers/acpi/processor.c 14 Jul 2004 04:56:25 -0000 1.1.1.1
+++ linux-2.6.8-rc1-mm1/drivers/acpi/processor.c 20 Jul 2004 15:31:46 -0000
@@ -2372,8 +2372,10 @@ acpi_processor_remove (
pr = (struct acpi_processor *) acpi_driver_data(device);
/* Unregister the idle handler when processor #0 is removed. */
- if (pr->id == 0)
+ if (pr->id == 0) {
pm_idle = pm_idle_save;
+ synchronize_kernel();
+ }
status = acpi_remove_notify_handler(pr->handle, ACPI_DEVICE_NOTIFY,
acpi_processor_notify);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH][2.4/2.6] Quiesce after changing ACPI idle thread
2004-07-22 15:30 ` [PATCH][2.4/2.6] " Zwane Mwaikambo
@ 2004-07-23 2:09 ` Zwane Mwaikambo
2004-07-27 9:33 ` Zwane Mwaikambo
2004-07-30 3:38 ` Len Brown
1 sibling, 1 reply; 5+ messages in thread
From: Zwane Mwaikambo @ 2004-07-23 2:09 UTC (permalink / raw)
To: Linux Kernel
Cc: Len Brown, shaohua.li, yi.zhu, Andrew Morton, Marcelo Tosatti
Marcelo, i'm full of shit obviously synchronize_kernel() won't work on
2.4 hmmm, i'll see what to do about that.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][2.4/2.6] Quiesce after changing ACPI idle thread
2004-07-23 2:09 ` Zwane Mwaikambo
@ 2004-07-27 9:33 ` Zwane Mwaikambo
0 siblings, 0 replies; 5+ messages in thread
From: Zwane Mwaikambo @ 2004-07-27 9:33 UTC (permalink / raw)
To: Linux Kernel
Cc: Len Brown, shaohua.li, yi.zhu, Andrew Morton, Marcelo Tosatti
On Thu, 22 Jul 2004, Zwane Mwaikambo wrote:
> Marcelo, i'm full of shit obviously synchronize_kernel() won't work on
> 2.4 hmmm, i'll see what to do about that.
Ok Marcelo, don't worry about this one, for this particular case Len says
we should leave it as is.
Thanks,
Zwane
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][2.4/2.6] Quiesce after changing ACPI idle thread
2004-07-22 15:30 ` [PATCH][2.4/2.6] " Zwane Mwaikambo
2004-07-23 2:09 ` Zwane Mwaikambo
@ 2004-07-30 3:38 ` Len Brown
1 sibling, 0 replies; 5+ messages in thread
From: Len Brown @ 2004-07-30 3:38 UTC (permalink / raw)
To: Zwane Mwaikambo
Cc: Linux Kernel, Shaohua Li, Yi Zhu, Andrew Morton, Marcelo Tosatti
applied to 2.6.
thanks Zwane.
-Len
On Thu, 2004-07-22 at 11:30, Zwane Mwaikambo wrote:
> (Please apply this patch instead of the previously posted one).
>
> This patch addresses the following bugzilla bug;
>
> http://bugzilla.kernel.org/show_bug.cgi?id=1716
>
> When unloading the processor module we modify the currently used idle
> thread (pm_idle), this causes an oops due to the idle thread text
> being
> unloaded. This should apply to both 2.6 and 2.4.
>
> Signed-off-by: Zwane Mwaikambo <zwane@fsmlabs.com>
>
> Index: linux-2.6.8-rc1-mm1/drivers/acpi/processor.c
> ===================================================================
> RCS file: /home/cvsroot/linux-2.6.8-rc1-mm1/drivers/acpi/processor.c,v
> retrieving revision 1.1.1.1
> diff -u -p -B -r1.1.1.1 processor.c
> --- linux-2.6.8-rc1-mm1/drivers/acpi/processor.c 14 Jul 2004
> 04:56:25 -0000 1.1.1.1
> +++ linux-2.6.8-rc1-mm1/drivers/acpi/processor.c 20 Jul 2004
> 15:31:46 -0000
> @@ -2372,8 +2372,10 @@ acpi_processor_remove (
> pr = (struct acpi_processor *) acpi_driver_data(device);
>
> /* Unregister the idle handler when processor #0 is removed.
> */
> - if (pr->id == 0)
> + if (pr->id == 0) {
> pm_idle = pm_idle_save;
> + synchronize_kernel();
> + }
>
> status = acpi_remove_notify_handler(pr->handle,
> ACPI_DEVICE_NOTIFY,
> acpi_processor_notify);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-07-30 3:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-22 15:16 [PATCH][2.6] Quiesce after changing ACPI idle thread Zwane Mwaikambo
2004-07-22 15:30 ` [PATCH][2.4/2.6] " Zwane Mwaikambo
2004-07-23 2:09 ` Zwane Mwaikambo
2004-07-27 9:33 ` Zwane Mwaikambo
2004-07-30 3:38 ` Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.