Re: [PATCH net-next 09/15] batman-adv: tt: extract removal of the superseded local entry

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]

https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260907081824.2474040-1-sw%40simonwunderlich.de?part=9

[...]
> > +/**
> > + * batadv_tt_global_purge_local() - drop the local entry of an announced client
> > + * @bat_priv: the bat priv with all the mesh interface information
> > + * @tt_global_entry: the global TT entry of the announced client
> > + * @flags: TT flags announced for this non-mesh client
> > + *
> > + * A client which is announced by another originator is no longer a local
> > + * client. Remove it from the local table and take over the WIFI flag it was
> > + * tracked with.
> > + */
> 
> Discovered by: opus-5 · Missed by: sonnet-5, gpt-5-6-sol, sashiko-gemini · Confirmed by: gpt-5-6-sol
> This isn't a bug, but should the new kernel-doc for
> batadv_tt_global_purge_local() mention the two things the body actually
> does beyond the summary?
> 
> The doc says removal from the local table happens, but multicast addresses
> take an early return and nothing is removed:
> 
> 	if (is_multicast_ether_addr(common->addr))
> 		return;
> 
> The doc also does not mention that the global entry's own flags are
> modified, not just the inherited WIFI flag:
> 
> 		if (!(flags & BATADV_TT_CLIENT_ROAM))
> 			common->flags &= ~BATADV_TT_CLIENT_ROAM;
> 
> Since flags_lock is documented in struct batadv_tt_common_entry as
> protecting both @flags and @batadv_tt_global_entry.roam_at, a reader of the
> new standalone helper might not expect the name purge_local() to also reset
> the global roaming state.
> 
> Both behaviours are unchanged from the previous inline code under the
> out_remove label in batadv_tt_global_add(), so this is only about the
> description of the new helper.


See https://patchwork.open-mesh.org/project/b.a.t.m.a.n./patch/20260908-sashiko-kdoc-v1-1-535b498f2519@narfation.org/

Regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]