All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ppc32: Fix booting on some OldWolrd Macs
@ 2004-08-18 21:37 Benjamin Herrenschmidt
  0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2004-08-18 21:37 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Linus Torvalds, Linux Kernel list, linuxppc-dev list

Hi !

It seems that on some OldWolrd macs, we don't get the OF stdout device,
thus the new set_preferred_console() dies at boot trying to dereference
a NULL pointer. Here's a fix:

===== arch/ppc/kernel/setup.c 1.59 vs edited =====
--- 1.59/arch/ppc/kernel/setup.c	2004-07-27 08:27:53 +10:00
+++ edited/arch/ppc/kernel/setup.c	2004-08-18 21:38:17 +10:00
@@ -484,6 +484,9 @@
 	char *name;
 	int offset;
 
+	if (of_stdout_device == NULL)
+		return -ENODEV;
+
 	/* The user has requested a console so this is already set up. */
 	if (strstr(saved_command_line, "console="))
 		return -EBUSY;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-08-18 21:47 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-18 21:37 [PATCH] ppc32: Fix booting on some OldWolrd Macs Benjamin Herrenschmidt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.