From: James Bottomley <James.Bottomley@SteelEye.com>
To: Jesse Barnes <jbarnes@engr.sgi.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Matthew Dobson <colpatch@us.ibm.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: SMP Panic caused by [PATCH] sched: consolidate sched domains
Date: 29 Aug 2004 12:58:22 -0400 [thread overview]
Message-ID: <1093798704.10973.15.camel@mulgrave> (raw)
In-Reply-To: <200408290948.06473.jbarnes@engr.sgi.com>
On Sun, 2004-08-29 at 12:48, Jesse Barnes wrote:
> But I think this breaks what the code is supposed to do. You're right that we
> shouldn't use cpu_online_map, but we should leave the nodemask in there and
> fix the code that sets it in the non-NUMA case instead.
Well, let's say it puts back the original behaviour. If you look at even
the NUMA code before these changes, it had cpu_possible_map in there.
I totally agree about fixing NUMA, it looks completely broken to me in
the way it handles cpu maps because node_to_cpumask(i) needs to expand
to cpu_possible_map for initialisation and cpu_online_map for
operation. Has anyone ever checked NUMA for hotplug CPU?
James
next prev parent reply other threads:[~2004-08-29 17:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-29 13:39 SMP Panic caused by [PATCH] sched: consolidate sched domains James Bottomley
2004-08-29 16:48 ` Jesse Barnes
2004-08-29 16:58 ` James Bottomley [this message]
2004-08-29 17:07 ` Jesse Barnes
2004-08-29 17:16 ` James Bottomley
2004-08-30 19:11 ` Matthew Dobson
2004-08-29 17:24 ` James Bottomley
2004-08-29 17:48 ` Nathan Lynch
2004-08-29 22:59 ` James Bottomley
2004-08-29 17:03 ` William Lee Irwin III
2004-08-29 17:09 ` James Bottomley
2004-08-29 17:22 ` William Lee Irwin III
2004-08-29 17:29 ` William Lee Irwin III
2004-08-29 17:40 ` William Lee Irwin III
2004-08-29 17:50 ` William Lee Irwin III
2004-08-29 23:13 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093798704.10973.15.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=jbarnes@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.