From: William Lee Irwin III <wli@holomorphy.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Jesse Barnes <jbarnes@engr.sgi.com>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Matthew Dobson <colpatch@us.ibm.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: SMP Panic caused by [PATCH] sched: consolidate sched domains
Date: Sun, 29 Aug 2004 10:50:58 -0700 [thread overview]
Message-ID: <20040829175058.GP5492@holomorphy.com> (raw)
In-Reply-To: <20040829174039.GO5492@holomorphy.com>
On Sun, Aug 29, 2004 at 10:40:39AM -0700, William Lee Irwin III wrote:
> Okay, if you prefer the #ifdef:
And for the other half of it:
Index: wait-2.6.9-rc1-mm1/kernel/sched.c
===================================================================
--- wait-2.6.9-rc1-mm1.orig/kernel/sched.c 2004-08-28 11:41:47.000000000 -0700
+++ wait-2.6.9-rc1-mm1/kernel/sched.c 2004-08-29 10:46:52.543081208 -0700
@@ -4224,7 +4224,11 @@
sd = &per_cpu(phys_domains, i);
group = cpu_to_phys_group(i);
*sd = SD_CPU_INIT;
+#ifdef CONFIG_NUMA
sd->span = nodemask;
+#else
+ sd->span = cpu_possible_map;
+#endif
sd->parent = p;
sd->groups = &sched_group_phys[group];
@@ -4262,6 +4266,7 @@
&cpu_to_isolated_group);
}
+#ifdef CONFIG_NUMA
/* Set up physical groups */
for (i = 0; i < MAX_NUMNODES; i++) {
cpumask_t nodemask = node_to_cpumask(i);
@@ -4273,6 +4278,10 @@
init_sched_build_groups(sched_group_phys, nodemask,
&cpu_to_phys_group);
}
+#else
+ init_sched_build_groups(sched_group_phys, cpu_possible_map,
+ &cpu_to_phys_group);
+#endif
#ifdef CONFIG_NUMA
/* Set up node groups */
next prev parent reply other threads:[~2004-08-29 17:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-29 13:39 SMP Panic caused by [PATCH] sched: consolidate sched domains James Bottomley
2004-08-29 16:48 ` Jesse Barnes
2004-08-29 16:58 ` James Bottomley
2004-08-29 17:07 ` Jesse Barnes
2004-08-29 17:16 ` James Bottomley
2004-08-30 19:11 ` Matthew Dobson
2004-08-29 17:24 ` James Bottomley
2004-08-29 17:48 ` Nathan Lynch
2004-08-29 22:59 ` James Bottomley
2004-08-29 17:03 ` William Lee Irwin III
2004-08-29 17:09 ` James Bottomley
2004-08-29 17:22 ` William Lee Irwin III
2004-08-29 17:29 ` William Lee Irwin III
2004-08-29 17:40 ` William Lee Irwin III
2004-08-29 17:50 ` William Lee Irwin III [this message]
2004-08-29 23:13 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040829175058.GP5492@holomorphy.com \
--to=wli@holomorphy.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=colpatch@us.ibm.com \
--cc=jbarnes@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.