From: Dave Hansen <haveblue@us.ibm.com>
To: Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
lhms <lhms-devel@lists.sourceforge.net>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC] buddy allocator withou bitmap(2) [3/3]
Date: Tue, 31 Aug 2004 09:35:54 -0700 [thread overview]
Message-ID: <1093970154.26660.4829.camel@nighthawk> (raw)
In-Reply-To: <4134573F.6060006@jp.fujitsu.com>
On Tue, 2004-08-31 at 03:47, Hiroyuki KAMEZAWA wrote:
> "Does a page's buddy page exist or not ?" is checked by following.
> ------------------------
> if ((address of buddy is smaller than that of page) &&
> (page->flags & PG_buddyend))
> this page has no buddy in this order.
> ------------------------
What about the top-of-the-zone buddyend pages? Are those covered
elsewhere?
> +static inline int page_is_buddy(struct page *page, int order)
> +{
> + if (PagePrivate(page) &&
> + (page_order(page) == order) &&
> + !(page->flags & (1 << PG_reserved)) &&
Please use a macro.
> if (order)
> destroy_compound_page(page, order);
> +
> mask = (~0UL) << order;
> page_idx = page - base;
Repeat after me: No whitespace changes. No whitespace changes. No
whitespace changes.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
lhms <lhms-devel@lists.sourceforge.net>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC] buddy allocator withou bitmap(2) [3/3]
Date: Tue, 31 Aug 2004 09:35:54 -0700 [thread overview]
Message-ID: <1093970154.26660.4829.camel@nighthawk> (raw)
In-Reply-To: <4134573F.6060006@jp.fujitsu.com>
On Tue, 2004-08-31 at 03:47, Hiroyuki KAMEZAWA wrote:
> "Does a page's buddy page exist or not ?" is checked by following.
> ------------------------
> if ((address of buddy is smaller than that of page) &&
> (page->flags & PG_buddyend))
> this page has no buddy in this order.
> ------------------------
What about the top-of-the-zone buddyend pages? Are those covered
elsewhere?
> +static inline int page_is_buddy(struct page *page, int order)
> +{
> + if (PagePrivate(page) &&
> + (page_order(page) == order) &&
> + !(page->flags & (1 << PG_reserved)) &&
Please use a macro.
> if (order)
> destroy_compound_page(page, order);
> +
> mask = (~0UL) << order;
> page_idx = page - base;
Repeat after me: No whitespace changes. No whitespace changes. No
whitespace changes.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-08-31 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-31 10:47 [RFC] buddy allocator withou bitmap(2) [3/3] Hiroyuki KAMEZAWA
2004-08-31 10:47 ` Hiroyuki KAMEZAWA
2004-08-31 16:35 ` Dave Hansen [this message]
2004-08-31 16:35 ` Dave Hansen
2004-08-31 22:58 ` [Lhms-devel] " Hiroyuki KAMEZAWA
2004-08-31 22:58 ` Hiroyuki KAMEZAWA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093970154.26660.4829.camel@nighthawk \
--to=haveblue@us.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.