Re: [PATCH v5 06/15] pc-bios/s390-ccw: Split virtio-ccw and generic virtio

[Thomas Huth <thuth@redhat.com>]

On 09/03/2026 01.35, jrossi@linux.ibm.com wrote:
> From: Jared Rossi <jrossi@linux.ibm.com>
> 
> Separate the CCW specific virtio routines and create generic wrappers for easier
> reuse of existing virtio functions with non-CCW devices.
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Eric Farman <farman@linux.ibm.com>
> Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
> ---
...
> diff --git a/pc-bios/s390-ccw/virtio-ccw.c b/pc-bios/s390-ccw/virtio-ccw.c
> new file mode 100644
> index 0000000000..ab98da90c3
> --- /dev/null
> +++ b/pc-bios/s390-ccw/virtio-ccw.c
> @@ -0,0 +1,241 @@
> +/*
> + * Virtio functionality for CCW devices
> + *
> + * Copyright (c) 2013 Alexander Graf <agraf@suse.de>
> + * Copyright 2025 IBM Corp.
> + *
> + * Author(s): Jared Rossi <jrossi@linux.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or (at
> + * your option) any later version. See the COPYING file in the top-level
> + * directory.
> + */

checkpatch.pl complains here:

  ERROR: New file 'pc-bios/s390-ccw/virtio-ccw.c' requires 
'SPDX-License-Identifier'
  ERROR: New file 'pc-bios/s390-ccw/virtio-ccw.c' must not have license 
boilerplate header text, only the SPDX-License-Identifier, unless this file 
was copied from existing code already having such text.

==> I'll add the SPDX tag to this patch.

  Thomas

...
> diff --git a/pc-bios/s390-ccw/virtio-ccw.h b/pc-bios/s390-ccw/virtio-ccw.h
> new file mode 100644
> index 0000000000..a506767eaa
> --- /dev/null
> +++ b/pc-bios/s390-ccw/virtio-ccw.h
> @@ -0,0 +1,24 @@
> +/*
> + * Virtio definitions for CCW devices
> + *
> + * Copyright 2025 IBM Corp.
> + * Author(s): Jared Rossi <jrossi@linux.ibm.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */...