* [PATCH] unexport do_execve/do_select
@ 2004-09-07 15:00 Christoph Hellwig
2004-09-07 17:02 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2004-09-07 15:00 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
These are basically shared code for native/32bit compat code, but as
CONFIG_COMPAT is a bool there's no need to export them.
--- 1.132/fs/exec.c 2004-08-27 09:02:34 +02:00
+++ edited/fs/exec.c 2004-09-07 14:25:35 +02:00
@@ -1187,8 +1187,6 @@
return retval;
}
-EXPORT_SYMBOL(do_execve);
-
int set_binfmt(struct linux_binfmt *new)
{
struct linux_binfmt *old = current->binfmt;
--- 1.23/fs/select.c 2004-08-27 09:02:39 +02:00
+++ edited/fs/select.c 2004-09-07 14:26:58 +02:00
@@ -267,8 +267,6 @@
return retval;
}
-EXPORT_SYMBOL(do_select);
-
static void *select_bits_alloc(int size)
{
return kmalloc(6 * size, GFP_KERNEL);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] unexport do_execve/do_select
2004-09-07 15:00 [PATCH] unexport do_execve/do_select Christoph Hellwig
@ 2004-09-07 17:02 ` Alan Cox
2004-09-07 18:06 ` Christoph Hellwig
2004-09-07 18:18 ` Arjan van de Ven
0 siblings, 2 replies; 4+ messages in thread
From: Alan Cox @ 2004-09-07 17:02 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, Linux Kernel Mailing List
On Maw, 2004-09-07 at 16:00, Christoph Hellwig wrote:
> These are basically shared code for native/32bit compat code, but as
> CONFIG_COMPAT is a bool there's no need to export them.
do_select at least used to be used by the xABI compatibility modules, is
that no longer the case ?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] unexport do_execve/do_select
2004-09-07 17:02 ` Alan Cox
@ 2004-09-07 18:06 ` Christoph Hellwig
2004-09-07 18:18 ` Arjan van de Ven
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2004-09-07 18:06 UTC (permalink / raw)
To: Alan Cox; +Cc: Christoph Hellwig, akpm, Linux Kernel Mailing List
On Tue, Sep 07, 2004 at 06:02:30PM +0100, Alan Cox wrote:
> On Maw, 2004-09-07 at 16:00, Christoph Hellwig wrote:
> > These are basically shared code for native/32bit compat code, but as
> > CONFIG_COMPAT is a bool there's no need to export them.
>
> do_select at least used to be used by the xABI compatibility modules, is
> that no longer the case ?
For Sparc, the only inkernel one that can be modular - no. For the x86
ABI modules half of the syscalls needs to be exported so the patch is
huge anyway.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] unexport do_execve/do_select
2004-09-07 17:02 ` Alan Cox
2004-09-07 18:06 ` Christoph Hellwig
@ 2004-09-07 18:18 ` Arjan van de Ven
1 sibling, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2004-09-07 18:18 UTC (permalink / raw)
To: Alan Cox; +Cc: Christoph Hellwig, akpm, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
On Tue, 2004-09-07 at 19:02, Alan Cox wrote:
> On Maw, 2004-09-07 at 16:00, Christoph Hellwig wrote:
> > These are basically shared code for native/32bit compat code, but as
> > CONFIG_COMPAT is a bool there's no need to export them.
>
> do_select at least used to be used by the xABI compatibility modules, is
> that no longer the case ?
I thought those no longer existed; lots of other stuff is missing for
those as well for sure.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-09-07 18:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-07 15:00 [PATCH] unexport do_execve/do_select Christoph Hellwig
2004-09-07 17:02 ` Alan Cox
2004-09-07 18:06 ` Christoph Hellwig
2004-09-07 18:18 ` Arjan van de Ven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.