* [PATCH] ppc: fix sungem NAPI (#2)
@ 2004-09-10 6:20 Benjamin Herrenschmidt
0 siblings, 0 replies; only message in thread
From: Benjamin Herrenschmidt @ 2004-09-10 6:20 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linus Torvalds, David S. Miller, Linux Kernel list
Hi !
(Resent with proper signed-off line after ack from David)
The recent sungem NAPI change introduced a bug: dev_kfree_skb() is called
within the spinlock, thus triggers all sort of WARN_ON's later on down the
stack.
This patch changes it to dev_kfree_skb_any(), I hope that is fine
as we aren't really in interrupt, are we ? (I don't know in what
context NAPI polling occurs, is it a timer IRQ ?)
Ben.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
--- 1.59/drivers/net/sungem.c 2004-09-08 06:17:59 +10:00
+++ edited/drivers/net/sungem.c 2004-09-10 13:44:18 +10:00
@@ -651,7 +651,7 @@
}
gp->net_stats.tx_packets++;
- dev_kfree_skb(skb);
+ dev_kfree_skb_any(skb);
}
gp->tx_old = entry;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-10 6:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-10 6:20 [PATCH] ppc: fix sungem NAPI (#2) Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.