[ppc patch] correct get_property prototype

[ppc patch] correct get_property prototype

[Hollis Blanchard]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Adjust a parameter type to be a bit more accurate. It won't cause 
compile changes, but knowing the proper/expected type would have saved 
me some debugging time when I was passing in the wrong value.

2004-09-13	Hollis Blanchard	<hollis@penguinppc.org>

	* boot/powerpc/ieee1275/ieee1275.c (grub_ieee1275_get_property): 
change "int
	handle" to "grub_ieee1275_phandle_t handle"
	* include/grub/powerpc/ieee1275/ieee1275.h 
(grub_ieee1275_get_property): Likewise.

-Hollis

[-- Attachment #2: 02-ppc-get_property.diff --]
[-- Type: application/octet-stream, Size: 1630 bytes --]

Index: boot/powerpc/ieee1275/ieee1275.c
===================================================================
RCS file: /cvsroot/grub/grub2/boot/powerpc/ieee1275/ieee1275.c,v
retrieving revision 1.3
diff -u -r1.3 ieee1275.c
--- boot/powerpc/ieee1275/ieee1275.c	27 Jul 2004 17:47:37 -0000	1.3
+++ boot/powerpc/ieee1275/ieee1275.c	14 Sep 2004 00:23:40 -0000
@@ -75,7 +75,8 @@
 }
 
 int
-grub_ieee1275_get_property (int handle, const char *property, void *buf,
+grub_ieee1275_get_property (grub_ieee1275_phandle_t handle,
+			    const char *property, void *buf,
 			    grub_size_t size, grub_size_t *actual)
 {
   struct get_property_args {
Index: include/grub/powerpc/ieee1275/ieee1275.h
===================================================================
RCS file: /cvsroot/grub/grub2/include/grub/powerpc/ieee1275/ieee1275.h,v
retrieving revision 1.3
diff -u -r1.3 ieee1275.h
--- include/grub/powerpc/ieee1275/ieee1275.h	27 Jul 2004 17:47:37 -0000	1.3
+++ include/grub/powerpc/ieee1275/ieee1275.h	14 Sep 2004 00:23:40 -0000
@@ -49,8 +49,9 @@
 uint32_t EXPORT_FUNC(grub_ieee1275_decode_int_4) (unsigned char *p);
 int EXPORT_FUNC(grub_ieee1275_finddevice) (char *name,
 					   grub_ieee1275_phandle_t *phandlep);
-int EXPORT_FUNC(grub_ieee1275_get_property) (int handle, const char *property,
-					     void *buf, grub_size_t size,
+int EXPORT_FUNC(grub_ieee1275_get_property) (grub_ieee1275_phandle_t handle,
+					     const char *property, void *buf,
+					     grub_size_t size,
 					     grub_size_t *actual);
 int EXPORT_FUNC(grub_ieee1275_next_property) (int handle, char *prev_prop,
 					      char *prop, int *flags);

Re: [ppc patch] correct get_property prototype

[Yoshinori K. Okuji]

On Tuesday 14 September 2004 03:04, Hollis Blanchard wrote:
> Adjust a parameter type to be a bit more accurate. It won't cause
> compile changes, but knowing the proper/expected type would have
> saved me some debugging time when I was passing in the wrong value.

I've checked in your patch. Thank you.

For the other patches for ppc architecture, I will leave Marco.

Okuji

Re: [ppc patch] correct get_property prototype

[M. Gerards]

Quoting "Yoshinori K. Okuji" <okuji@enbug.org>:

> On Tuesday 14 September 2004 03:04, Hollis Blanchard wrote:
> > Adjust a parameter type to be a bit more accurate. It won't cause
> > compile changes, but knowing the proper/expected type would have
> > saved me some debugging time when I was passing in the wrong value.
> 
> I've checked in your patch. Thank you.
> 
> For the other patches for ppc architecture, I will leave Marco.

Sure.  I have to test some patches as well because some things might break
the support for the new world macs.

Thanks,
Marco