From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@osdl.org>
Cc: netfilter-devel@lists.netfilter.org,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] ip_nat_ftp doesn't register any ports by default.
Date: Thu, 16 Sep 2004 08:07:06 +1000 [thread overview]
Message-ID: <1095286006.1940.5.camel@bach> (raw)
Linus, please apply ASAP. This would be embarrassing: ip_nat_ftp broke
in recent conversion to module_param_array().
Name: Fix ip_nat_ftp registration when no ports= arg
Status: Trivial
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
FTP NAT module doesn't register anything with no args. Oops.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .6124-linux-2.6.9-rc2-bk2/net/ipv4/netfilter/ip_nat_ftp.c .6124-linux-2.6.9-rc2-bk2.updated/net/ipv4/netfilter/ip_nat_ftp.c
--- .6124-linux-2.6.9-rc2-bk2/net/ipv4/netfilter/ip_nat_ftp.c 2004-09-16 00:17:16.000000000 +1000
+++ .6124-linux-2.6.9-rc2-bk2.updated/net/ipv4/netfilter/ip_nat_ftp.c 2004-09-16 08:05:38.000000000 +1000
@@ -297,7 +297,7 @@ static int __init init(void)
char *tmpname;
if (ports_c == 0)
- ports[ports_c] = FTP_PORT;
+ ports[ports_c++] = FTP_PORT;
for (i = 0; i < ports_c; i++) {
ftp[i].tuple.dst.protonum = IPPROTO_TCP;
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
reply other threads:[~2004-09-15 22:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095286006.1940.5.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.