* [PATCH] ip_nat_ftp doesn't register any ports by default.
@ 2004-09-15 22:07 Rusty Russell
0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2004-09-15 22:07 UTC (permalink / raw)
To: Linus Torvalds; +Cc: netfilter-devel, lkml - Kernel Mailing List
Linus, please apply ASAP. This would be embarrassing: ip_nat_ftp broke
in recent conversion to module_param_array().
Name: Fix ip_nat_ftp registration when no ports= arg
Status: Trivial
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
FTP NAT module doesn't register anything with no args. Oops.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .6124-linux-2.6.9-rc2-bk2/net/ipv4/netfilter/ip_nat_ftp.c .6124-linux-2.6.9-rc2-bk2.updated/net/ipv4/netfilter/ip_nat_ftp.c
--- .6124-linux-2.6.9-rc2-bk2/net/ipv4/netfilter/ip_nat_ftp.c 2004-09-16 00:17:16.000000000 +1000
+++ .6124-linux-2.6.9-rc2-bk2.updated/net/ipv4/netfilter/ip_nat_ftp.c 2004-09-16 08:05:38.000000000 +1000
@@ -297,7 +297,7 @@ static int __init init(void)
char *tmpname;
if (ports_c == 0)
- ports[ports_c] = FTP_PORT;
+ ports[ports_c++] = FTP_PORT;
for (i = 0; i < ports_c; i++) {
ftp[i].tuple.dst.protonum = IPPROTO_TCP;
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-09-15 22:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-15 22:07 [PATCH] ip_nat_ftp doesn't register any ports by default Rusty Russell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.