Re: [BUG] ub.c badness in current bk

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Sat, 2004-09-18 at 02:04, Pete Zaitcev wrote:
> On Fri, 17 Sep 2004 19:46:34 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
> > Ok, here's a modified patch that fixes the problem for me.
> 
> > +	ret = sc->changed;
> > +	/* P3 */ printk("%s: %s changed\n", sc->name, ret ? "is": "was not");
> > +	
> > +	sc->changed = 0;
> >  	return sc->changed;
> >  }
> 
> You return zero always. I don't think it's supposed to be that way.
> I'm sorry, but I cannot apply it. I'll look for a better solution.

Oops, my wrong, it indeed doesn't make sense... Well, the problem is definitely
around here anyway... I'll do more tests when I'm more awake this week-end, the
above was done while I was fairly tired ;)

Ben.