From: Pete Zaitcev <zaitcev@redhat.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>, zaitcev@redhat.com
Subject: Re: [BUG] ub.c badness in current bk
Date: Fri, 17 Sep 2004 09:04:48 -0700 [thread overview]
Message-ID: <20040917090448.32ff763c@lembas.zaitcev.lan> (raw)
In-Reply-To: <1095414394.13531.77.camel@gaston>
On Fri, 17 Sep 2004 19:46:34 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> Ok, here's a modified patch that fixes the problem for me.
> + ret = sc->changed;
> + /* P3 */ printk("%s: %s changed\n", sc->name, ret ? "is": "was not");
> +
> + sc->changed = 0;
> return sc->changed;
> }
You return zero always. I don't think it's supposed to be that way.
I'm sorry, but I cannot apply it. I'll look for a better solution.
-- Pete
next prev parent reply other threads:[~2004-09-17 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1095300780.10032.linux-kernel2news@redhat.com>
2004-09-16 6:17 ` [BUG] ub.c badness in current bk Pete Zaitcev
2004-09-17 7:29 ` Pete Zaitcev
2004-09-17 9:46 ` Benjamin Herrenschmidt
2004-09-17 16:04 ` Pete Zaitcev [this message]
2004-09-18 0:08 ` Benjamin Herrenschmidt
2004-09-18 0:12 ` Benjamin Herrenschmidt
2004-09-18 1:04 ` Benjamin Herrenschmidt
2004-09-18 2:08 ` Benjamin Herrenschmidt
2004-09-20 3:21 ` Pete Zaitcev
2004-09-20 3:37 ` Benjamin Herrenschmidt
2004-09-22 1:44 ` Pete Zaitcev
2004-09-16 2:06 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040917090448.32ff763c@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.