From: adrian@humboldt.co.uk (Adrian Cox)
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
sensors@Stimpy.netroedge.com
Cc: Michael Hunold <hunold-ml@web.de>, Jon Smirl <jonsmirl@gmail.com>,
Greg KH <greg@kroah.com>
Subject: [PATCH][2.6] Add command function to struct i2c_adapter
Date: Thu, 19 May 2005 06:25:17 +0000 [thread overview]
Message-ID: <1095877951.18365.232.camel@localhost> (raw)
In-Reply-To: <20040922122848.M14129@linux-fr.org>
On Wed, 2004-09-22 at 14:38, Jean Delvare wrote:
> Aha, this is an interesting point (which was missing from your previous
> explanation). The base of your proposal would be to have several small i2c
> "trees" (where a tree is a list of adapters and a list of clients) instead of
> a larger, unique one. This would indeed solve a number of problems, and I
> admit that it is somehow equivalent to Michael's classes in that it
> efficiently prevents the hardware monitoring clients from probing the video
> stuff. The rest is just details internal to each "tree". As I understand it,
> each video device would be a tree on itself, while the whole hardware
> monitoring stuff would constitute one (bigger) tree. Correct?
I've been rereading the code, and it could be even simpler. How about
this:
1) The card driver defines an i2c_adapter structure, but never calls
i2c_add_adapter(). The only extra thing it needs to do is to initialise
the semaphores in the structure.
2) The frontend calls i2c_transfer() directly.
3) The i2c core never gets involved, and there is never any i2c_client
structure.
This gives us the required reuse of the I2C algo-bit code, without any
of the list walking or device probing being required.
- Adrian Cox
Humboldt Solutions Ltd.
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Cox <adrian@humboldt.co.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
sensors@Stimpy.netroedge.com
Cc: Michael Hunold <hunold-ml@web.de>, Jon Smirl <jonsmirl@gmail.com>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH][2.6] Add command function to struct i2c_adapter
Date: Wed, 22 Sep 2004 19:32:31 +0100 [thread overview]
Message-ID: <1095877951.18365.232.camel@localhost> (raw)
In-Reply-To: <20040922122848.M14129@linux-fr.org>
On Wed, 2004-09-22 at 14:38, Jean Delvare wrote:
> Aha, this is an interesting point (which was missing from your previous
> explanation). The base of your proposal would be to have several small i2c
> "trees" (where a tree is a list of adapters and a list of clients) instead of
> a larger, unique one. This would indeed solve a number of problems, and I
> admit that it is somehow equivalent to Michael's classes in that it
> efficiently prevents the hardware monitoring clients from probing the video
> stuff. The rest is just details internal to each "tree". As I understand it,
> each video device would be a tree on itself, while the whole hardware
> monitoring stuff would constitute one (bigger) tree. Correct?
I've been rereading the code, and it could be even simpler. How about
this:
1) The card driver defines an i2c_adapter structure, but never calls
i2c_add_adapter(). The only extra thing it needs to do is to initialise
the semaphores in the structure.
2) The frontend calls i2c_transfer() directly.
3) The i2c core never gets involved, and there is never any i2c_client
structure.
This gives us the required reuse of the I2C algo-bit code, without any
of the list walking or device probing being required.
- Adrian Cox
Humboldt Solutions Ltd.
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-20 17:19 [PATCH][2.6] Add command function to struct i2c_adapter Michael Hunold
2004-09-21 15:41 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-09-21 17:10 ` Michael Hunold
2005-05-19 6:25 ` Michael Hunold
2004-09-21 17:39 ` Jon Smirl
2005-05-19 6:25 ` Jon Smirl
2004-09-21 18:05 ` Michael Hunold
2005-05-19 6:25 ` Michael Hunold
2004-09-22 8:56 ` Adrian Cox
2005-05-19 6:25 ` Adrian Cox
2004-09-22 12:08 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-09-22 11:54 ` Adrian Cox
2005-05-19 6:25 ` Adrian Cox
2004-09-22 13:38 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-09-22 13:13 ` Adrian Cox
2005-05-19 6:25 ` Adrian Cox
2004-09-22 15:40 ` Jon Smirl
2005-05-19 6:25 ` Jon Smirl
2004-09-22 15:56 ` Adrian Cox
2005-05-19 6:25 ` Adrian Cox
2004-09-22 16:07 ` Jon Smirl
2005-05-19 6:25 ` Jon Smirl
2004-09-22 16:51 ` Adrian Cox
2005-05-19 6:25 ` Adrian Cox
2004-09-22 17:17 ` Jon Smirl
2005-05-19 6:25 ` Jon Smirl
2004-09-22 18:55 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-09-22 18:32 ` Adrian Cox [this message]
2005-05-19 6:25 ` Adrian Cox
2004-09-22 20:04 ` Mark M. Hoffman
2005-05-19 6:25 ` Mark M. Hoffman
2004-09-23 7:41 ` Michael Hunold
2005-05-19 6:25 ` Michael Hunold
2004-09-23 7:48 ` Michael Hunold
2005-05-19 6:25 ` Michael Hunold
2004-09-23 7:09 ` Michael Hunold
2005-05-19 6:25 ` Michael Hunold
2004-09-23 20:18 ` Adrian Cox
2005-05-19 6:25 ` Adrian Cox
2004-09-21 20:33 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-09-21 21:02 ` Jon Smirl
2005-05-19 6:25 ` Jon Smirl
2004-09-24 17:06 ` Michael Hunold
2005-05-19 6:25 ` Michael Hunold
2004-09-24 18:05 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-09-24 20:21 ` Michael Hunold
2005-05-19 6:25 ` Michael Hunold
2004-10-01 6:52 ` Greg KH
2005-05-19 6:25 ` Greg KH
2004-10-01 12:22 ` Adrian Cox
2005-05-19 6:25 ` Adrian Cox
2004-10-01 13:57 ` Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-10-01 23:41 ` Greg KH
2005-05-19 6:25 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-05-19 6:25 [Fwd: [PATCH][2.6] Add command function to struct i2c_adapter] Michael Hunold
2004-09-21 13:28 ` [PATCH][2.6] Add command function to struct i2c_adapter Jean Delvare
2005-05-19 6:25 ` Jean Delvare
2004-09-21 14:38 ` Michael Hunold
2005-05-19 6:25 ` Michael Hunold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1095877951.18365.232.camel@localhost \
--to=adrian@humboldt.co.uk \
--cc=greg@kroah.com \
--cc=hunold-ml@web.de \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@Stimpy.netroedge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.