All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Fulghum <paulkf@microgate.com>
To: "Feldman, Scott" <scott.feldman@intel.com>
Cc: "Venkatesan, Ganesh" <ganesh.venkatesan@intel.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: RE: 2.6.9-rc2-mm4 e100 enable_irq unbalanced from
Date: Tue, 28 Sep 2004 22:06:20 -0500	[thread overview]
Message-ID: <1096427180.6003.49.camel@at2.pipehead.org> (raw)
In-Reply-To: <C6F5CF431189FA4CBAEC9E7DD5441E0103AF6375@orsmsx402.amr.corp.intel.com>

On Tue, 2004-09-28 at 16:03, Feldman, Scott wrote:
> Maybe just
> the disable_irq call is all that is needed to solve the spurious
> interrupt case?

That would not work either.

request_irq() clears the enable/disable depth
only when registering the first device on that
interrupt.

If a device is sharing an interrupt with e100
and calls request_irq() before e100, then the
disable_irq() requires a matching enable_irq().

If e100 is the only or first device on
that interrupt, then the enable_irq() causes
the warning because the depth has been reset.

It is interesting behavior for request_irq.
I don't know if it was planned that way,
or is an unexpected artifact.
It makes the effect of the disable_irq call
indeterminate (to the driver) if made
before registering with the interrupt.

-- 
Paul Fulghum
paulkf@microgate.com



  reply	other threads:[~2004-09-29  3:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-28 21:03 2.6.9-rc2-mm4 e100 enable_irq unbalanced from Feldman, Scott
2004-09-29  3:06 ` Paul Fulghum [this message]
2004-09-29 12:13   ` Alan Cox
2004-09-29 13:31     ` Russell King
  -- strict thread matches above, loose matches on Subject: below --
2004-09-27 19:24 Paul Fulghum
2004-09-27 21:12 ` Paul Fulghum
2004-09-30 18:21   ` Jeremy Fitzhardinge
2004-09-27 23:00 ` J.A. Magallon
2004-09-27 23:09   ` Paul Fulghum
2004-09-28 22:13     ` J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1096427180.6003.49.camel@at2.pipehead.org \
    --to=paulkf@microgate.com \
    --cc=ganesh.venkatesan@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=scott.feldman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.