From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Paul Fulghum <paulkf@microgate.com>
Cc: "Feldman, Scott" <scott.feldman@intel.com>,
"Venkatesan, Ganesh" <ganesh.venkatesan@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: 2.6.9-rc2-mm4 e100 enable_irq unbalanced from
Date: Wed, 29 Sep 2004 13:13:26 +0100 [thread overview]
Message-ID: <1096460004.15905.9.camel@localhost.localdomain> (raw)
In-Reply-To: <1096427180.6003.49.camel@at2.pipehead.org>
On Mer, 2004-09-29 at 04:06, Paul Fulghum wrote:
> It is interesting behavior for request_irq.
> I don't know if it was planned that way,
> or is an unexpected artifact.
> It makes the effect of the disable_irq call
> indeterminate (to the driver) if made
> before registering with the interrupt.
Essentially the code believes that you cannot use
disable_irq() until you've requested it. You can
however in 2.6 call request_irq with local interrupts
disabled.
We have a fundamental API design problem going back to
day one. The API IMHO should really be
struct irq *irq;
irq = allocate_irq(5, ...)
enable_irq(irq);
That would fix
- Drivers failing to load/init under freak low memory situations
- How to cleanly report irqs (because each irq can now have ->name)
- How to tell which shared irq users are disabled/enabled for the irq
poll/recovery code I posted (and is testing in -mm).
Unfortunately it would require changes to rather a lot of code.
next prev parent reply other threads:[~2004-09-29 13:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-28 21:03 2.6.9-rc2-mm4 e100 enable_irq unbalanced from Feldman, Scott
2004-09-29 3:06 ` Paul Fulghum
2004-09-29 12:13 ` Alan Cox [this message]
2004-09-29 13:31 ` Russell King
-- strict thread matches above, loose matches on Subject: below --
2004-09-27 19:24 Paul Fulghum
2004-09-27 21:12 ` Paul Fulghum
2004-09-30 18:21 ` Jeremy Fitzhardinge
2004-09-27 23:00 ` J.A. Magallon
2004-09-27 23:09 ` Paul Fulghum
2004-09-28 22:13 ` J.A. Magallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1096460004.15905.9.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ganesh.venkatesan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
--cc=scott.feldman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.