From: Dave Hansen <haveblue@us.ibm.com>
To: Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
lhms <lhms-devel@lists.sourceforge.net>,
Andrew Morton <akpm@osdl.org>,
William Lee Irwin III <wli@holomorphy.com>,
"Luck, Tony" <tony.luck@intel.com>,
Hirokazu Takahashi <taka@valinux.co.jp>
Subject: Re: [PATCH] no buddy bitmap patch : for ia64 [2/2]
Date: Thu, 07 Oct 2004 08:43:13 -0700 [thread overview]
Message-ID: <1097163793.3625.47.camel@localhost> (raw)
In-Reply-To: <4165399D.7010600@jp.fujitsu.com>
On Thu, 2004-10-07 at 05:42, Hiroyuki KAMEZAWA wrote:
> #ifdef CONFIG_VIRTUAL_MEM_MAP
> extern int ia64_pfn_valid (unsigned long pfn);
> +#define HOLES_IN_ZONE 1
> #else
> # define ia64_pfn_valid(pfn) 1
> #endif
The real way to do this is to put it in a Kconfig file.
something like:
config HOLES_IN_ZONE
bool
depends on VIRTUAL_MEM_MAP
right below where 'config VIRTUAL_MEM_MAP' is defined. That way, if any
other architectures need it, they alter their Kconfig files instead of
headers. Also, it leaves the possibility of having an arch-independent
Kconfig file for memory-related options which I'd like to do in the
future.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Hiroyuki KAMEZAWA <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
lhms <lhms-devel@lists.sourceforge.net>,
Andrew Morton <akpm@osdl.org>,
William Lee Irwin III <wli@holomorphy.com>,
"Luck, Tony" <tony.luck@intel.com>,
Hirokazu Takahashi <taka@valinux.co.jp>
Subject: Re: [PATCH] no buddy bitmap patch : for ia64 [2/2]
Date: Thu, 07 Oct 2004 08:43:13 -0700 [thread overview]
Message-ID: <1097163793.3625.47.camel@localhost> (raw)
In-Reply-To: <4165399D.7010600@jp.fujitsu.com>
On Thu, 2004-10-07 at 05:42, Hiroyuki KAMEZAWA wrote:
> #ifdef CONFIG_VIRTUAL_MEM_MAP
> extern int ia64_pfn_valid (unsigned long pfn);
> +#define HOLES_IN_ZONE 1
> #else
> # define ia64_pfn_valid(pfn) 1
> #endif
The real way to do this is to put it in a Kconfig file.
something like:
config HOLES_IN_ZONE
bool
depends on VIRTUAL_MEM_MAP
right below where 'config VIRTUAL_MEM_MAP' is defined. That way, if any
other architectures need it, they alter their Kconfig files instead of
headers. Also, it leaves the possibility of having an arch-independent
Kconfig file for memory-related options which I'd like to do in the
future.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-10-07 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-07 12:42 [PATCH] no buddy bitmap patch : for ia64 [2/2] Hiroyuki KAMEZAWA
2004-10-07 12:42 ` Hiroyuki KAMEZAWA
2004-10-07 15:43 ` Dave Hansen [this message]
2004-10-07 15:43 ` Dave Hansen
2004-10-08 0:43 ` [Lhms-devel] " Hiroyuki KAMEZAWA
2004-10-08 0:43 ` Hiroyuki KAMEZAWA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097163793.3625.47.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=taka@valinux.co.jp \
--cc=tony.luck@intel.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.