From: James Bottomley <jejb@steeleye.com>
To: "Salyzyn, Mark" <mark_salyzyn@adaptec.com>
Cc: Mark Haverkamp <markh@osdl.org>, Christoph Hellwig <hch@lst.de>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH] kill aac_io_done
Date: 11 Oct 2004 11:55:44 -0500 [thread overview]
Message-ID: <1097513750.2029.152.camel@mulgrave> (raw)
In-Reply-To: <60807403EABEB443939A5A7AA8A7458B2FC33F@otce2k01.adaptec.com>
On Mon, 2004-10-11 at 11:07, Salyzyn, Mark wrote:
> The host lock around scsi_done() was there *before* I started
> maintaining this driver. I believe the reasoning could be as simple as
> `we had an io_request_lock there, so we should need a host_lock for the
> same reasons'. I believe this locking is a legacy of code prior to
> 2.1.95 though...
I think it was a 2.2 requirement; the then "new" SCSI code in 2.4 moved
to completing requests in the bottom half handler which queue was
protected by the scsi_bhqueue_lock in the scsi_done() routine and no
longer needed the io_request lock.
In 2.6 the BH handler became a softirq thanks to Mattew Wilcox.
James
next prev parent reply other threads:[~2004-10-11 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 16:07 [PATCH] kill aac_io_done Salyzyn, Mark
2004-10-11 16:55 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-09 13:46 Christoph Hellwig
2004-10-11 15:48 ` Mark Haverkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097513750.2029.152.camel@mulgrave \
--to=jejb@steeleye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.