From: Christoph Hellwig <hch@lst.de>
To: mark_salyzyn@adaptec.com, jejb@steeleye.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] kill aac_io_done
Date: Sat, 9 Oct 2004 15:46:57 +0200 [thread overview]
Message-ID: <20041009134657.GA20075@lst.de> (raw)
there's not need anymore to take the host lock before calling ->done
--- 1.29/drivers/scsi/aacraid/aachba.c 2004-10-01 17:10:08 +02:00
+++ edited/drivers/scsi/aacraid/aachba.c 2004-10-09 14:38:04 +02:00
@@ -335,15 +335,6 @@
return status;
}
-static void aac_io_done(struct scsi_cmnd * scsicmd)
-{
- unsigned long cpu_flags;
- struct Scsi_Host *host = scsicmd->device->host;
- spin_lock_irqsave(host->host_lock, cpu_flags);
- scsicmd->scsi_done(scsicmd);
- spin_unlock_irqrestore(host->host_lock, cpu_flags);
-}
-
static void get_container_name_callback(void *context, struct fib * fibptr)
{
struct aac_get_name_resp * get_name_reply;
@@ -375,7 +366,8 @@
fib_complete(fibptr);
fib_free(fibptr);
- aac_io_done(scsicmd);
+
+ scsicmd->scsi_done(scsicmd);
}
/**
@@ -735,7 +727,7 @@
fib_complete(fibptr);
fib_free(fibptr);
- aac_io_done(scsicmd);
+ scsicmd->scsi_done(scsicmd);
}
static void write_callback(void *context, struct fib * fibptr)
@@ -782,7 +774,7 @@
fib_complete(fibptr);
fib_free(fibptr);
- aac_io_done(scsicmd);
+ scsicmd->scsi_done(scsicmd);
}
int aac_read(struct scsi_cmnd * scsicmd, int cid)
@@ -891,7 +883,7 @@
* For some reason, the Fib didn't queue, return QUEUE_FULL
*/
scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 | SAM_STAT_TASK_SET_FULL;
- aac_io_done(scsicmd);
+ scsicmd->scsi_done(scsicmd);
fib_complete(cmd_fibcontext);
fib_free(cmd_fibcontext);
return -1;
@@ -927,7 +919,7 @@
*/
if (!(cmd_fibcontext = fib_alloc(dev))) {
scsicmd->result = DID_ERROR << 16;
- aac_io_done(scsicmd);
+ scsicmd->scsi_done(scsicmd);
return -1;
}
fib_init(cmd_fibcontext);
@@ -1000,7 +992,7 @@
* For some reason, the Fib didn't queue, return QUEUE_FULL
*/
scsicmd->result = DID_OK << 16 | COMMAND_COMPLETE << 8 | SAM_STAT_TASK_SET_FULL;
- aac_io_done(scsicmd);
+ scsicmd->scsi_done(scsicmd);
fib_complete(cmd_fibcontext);
fib_free(cmd_fibcontext);
@@ -1568,7 +1560,7 @@
fib_complete(fibptr);
fib_free(fibptr);
- aac_io_done(scsicmd);
+ scsicmd->scsi_done(scsicmd);
}
/**
next reply other threads:[~2004-10-09 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-09 13:46 Christoph Hellwig [this message]
2004-10-11 15:48 ` [PATCH] kill aac_io_done Mark Haverkamp
-- strict thread matches above, loose matches on Subject: below --
2004-10-11 16:07 Salyzyn, Mark
2004-10-11 16:55 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041009134657.GA20075@lst.de \
--to=hch@lst.de \
--cc=jejb@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.