From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: dominik.karall@gmx.net,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.9-rc3-mm2
Date: Fri, 15 Oct 2004 12:05:25 +1000 [thread overview]
Message-ID: <1097805925.22673.70.camel@localhost.localdomain> (raw)
In-Reply-To: <20041014184427.65d75324.akpm@osdl.org>
On Fri, 2004-10-15 at 11:44, Andrew Morton wrote:
> Rusty Russell <rusty@rustcorp.com.au> wrote:
> > Please, please please! Never use per_cpu(XXX, smp_processor_id())!
>
> Why?
Because that's what get_cpu_var() does, and an arch might not need to
get the processor id to do it. As more things get per-cpu-ified, and
smp_processor_id() for its own sake becomes more unusual, I expect archs
to go to smp_processor_id() as a per-cpu variable, and a register
holding the per-cpu offset. (This needs a real dynamic per-cpu
allocator, as well, which I've been meaning to polish off).
> We were getting warnings from somewhere or other due to smp_processor_id()
> within preemptible code - I don't recall the callsite.
That's weird, but implies bogosity in the caller. Covering it up like
this is not necessarily a win.
Rusty.
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next prev parent reply other threads:[~2004-10-15 2:05 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 9:02 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 10:36 ` 2.6.9-rc3-mm2 Mathieu Segaud
2004-10-04 15:39 ` 2.6.9-rc3-mm2 Norberto Bensa
[not found] ` <87k6u6mp5z.fsf@barad-dur.crans.org>
2004-10-04 16:33 ` 2.6.9-rc3-mm2 Norberto Bensa
2004-10-04 12:15 ` 2.6.9-rc3-mm2 Stephane Jourdois
2004-10-05 0:36 ` 2.6.9-rc3-mm2 Andrew Rodland
2004-10-05 17:45 ` 2.6.9-rc3-mm2 Stephane Jourdois
2004-10-04 12:46 ` 2.6.9-rc3-mm2 Stefano Rivoir
2004-10-04 19:18 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:12 ` 2.6.9-rc3-mm2 Grant Wilson
2004-10-04 21:32 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:39 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:52 ` 2.6.9-rc3-mm2 Grant Wilson
2004-10-04 22:02 ` 2.6.9-rc3-mm2 Hua Zhong
2004-10-04 22:11 ` 2.6.9-rc3-mm2 Grant Wilson
2004-10-05 6:56 ` 2.6.9-rc3-mm2 Stefano Rivoir
2004-10-04 17:13 ` 2.6.9-rc3-mm2 Pasi Savolainen
2004-10-05 9:25 ` 2.6.9-rc3-mm2 Peter Zijlstra
2004-10-05 9:30 ` 2.6.9-rc3-mm2 Peter Zijlstra
2004-10-05 12:06 ` 2.6.9-rc3-mm2 Hugh Dickins
2004-10-05 13:28 ` 2.6.9-rc3-mm2 Peter Zijlstra
2004-10-06 10:54 ` 2.6.9-rc3-mm2 Hugh Dickins
2004-10-06 10:57 ` 2.6.9-rc3-mm2 Ingo Molnar
2004-10-07 0:53 ` 2.6.9-rc3-mm2 Pasi Savolainen
2004-10-04 17:19 ` 2.6.9-rc3-mm2 (compile stats) John Cherry
2004-10-04 19:56 ` 2.6.9-rc3-mm2 Christian Borntraeger
2004-10-04 21:39 ` 2.6.9-rc3-mm2 Dominik Karall
2004-10-04 23:41 ` 2.6.9-rc3-mm2 ip_conntrack problems Ed Tomlinson
2004-10-05 0:08 ` Andrew Morton
2004-10-05 23:13 ` Ed Tomlinson
2004-10-05 23:53 ` Andrew Morton
2004-10-05 3:12 ` 2.6.9-rc3-mm2 Andrew Rodland
2004-10-05 9:25 ` 2.6.9-rc3-mm2 Dominik Karall
2004-10-05 14:07 ` 2.6.9-rc3-mm2 Dominik Karall
2004-10-05 14:21 ` 2.6.9-rc3-mm2 Con Kolivas
2004-10-15 1:38 ` 2.6.9-rc3-mm2 Rusty Russell
2004-10-15 1:44 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-15 2:05 ` Rusty Russell [this message]
2004-10-15 2:09 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-15 3:07 ` 2.6.9-rc3-mm2 Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2004-10-04 10:40 2.6.9-rc3-mm2 Karsten Wiese
2004-10-06 20:28 ` 2.6.9-rc3-mm2 Hanna Linder
2004-10-04 14:34 2.6.9-rc3-mm2 Karsten Wiese
2004-10-04 19:23 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 19:25 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:26 ` 2.6.9-rc3-mm2 Ingo Molnar
2004-10-04 21:35 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:37 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:48 ` 2.6.9-rc3-mm2 Ingo Molnar
2004-10-05 0:05 ` 2.6.9-rc3-mm2 Karsten Wiese
2004-10-05 0:17 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-07 5:55 2.6.9-rc3-mm2 Sid Boyce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1097805925.22673.70.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=dominik.karall@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.