From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: annabellesgarden@yahoo.de, linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc3-mm2
Date: Mon, 4 Oct 2004 23:48:55 +0200 [thread overview]
Message-ID: <20041004214855.GA19748@elte.hu> (raw)
In-Reply-To: <20041004143738.5ca9c43f.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> Ingo Molnar <mingo@elte.hu> wrote:
> >
> > Must not put side-effects into a macro that is NOP on
> > !SMP.
>
> This one, too:
>
> - per_cpu(ip_conntrack_stat, get_cpu()).count++; \
> - put_cpu(); \
btw., also remove or fix the get_cpu_ptr() definition in percpu.h, it's
buggy for the same reason, but fortunately unused.
Ingo
next prev parent reply other threads:[~2004-10-04 21:50 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 14:34 2.6.9-rc3-mm2 Karsten Wiese
2004-10-04 19:23 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 19:25 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:26 ` 2.6.9-rc3-mm2 Ingo Molnar
2004-10-04 21:35 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:35 ` [patch, 2.6.9-rc3-mm2] preemption debugging Ingo Molnar
2004-10-04 21:37 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:48 ` Ingo Molnar [this message]
2004-10-05 0:05 ` 2.6.9-rc3-mm2 Karsten Wiese
2004-10-05 0:17 ` 2.6.9-rc3-mm2 Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2004-10-07 5:55 2.6.9-rc3-mm2 Sid Boyce
2004-10-04 10:40 2.6.9-rc3-mm2 Karsten Wiese
2004-10-06 20:28 ` 2.6.9-rc3-mm2 Hanna Linder
2004-10-04 9:02 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 10:36 ` 2.6.9-rc3-mm2 Mathieu Segaud
2004-10-04 15:39 ` 2.6.9-rc3-mm2 Norberto Bensa
[not found] ` <87k6u6mp5z.fsf@barad-dur.crans.org>
2004-10-04 16:33 ` 2.6.9-rc3-mm2 Norberto Bensa
2004-10-04 12:15 ` 2.6.9-rc3-mm2 Stephane Jourdois
2004-10-05 0:36 ` 2.6.9-rc3-mm2 Andrew Rodland
2004-10-05 17:45 ` 2.6.9-rc3-mm2 Stephane Jourdois
2004-10-04 12:46 ` 2.6.9-rc3-mm2 Stefano Rivoir
2004-10-04 19:18 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:12 ` 2.6.9-rc3-mm2 Grant Wilson
2004-10-04 21:32 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:39 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-04 21:52 ` 2.6.9-rc3-mm2 Grant Wilson
2004-10-04 22:02 ` 2.6.9-rc3-mm2 Hua Zhong
2004-10-04 22:11 ` 2.6.9-rc3-mm2 Grant Wilson
2004-10-05 6:56 ` 2.6.9-rc3-mm2 Stefano Rivoir
2004-10-04 17:13 ` 2.6.9-rc3-mm2 Pasi Savolainen
2004-10-05 9:25 ` 2.6.9-rc3-mm2 Peter Zijlstra
2004-10-05 9:30 ` 2.6.9-rc3-mm2 Peter Zijlstra
2004-10-05 12:06 ` 2.6.9-rc3-mm2 Hugh Dickins
2004-10-05 13:28 ` 2.6.9-rc3-mm2 Peter Zijlstra
2004-10-06 10:54 ` 2.6.9-rc3-mm2 Hugh Dickins
2004-10-06 10:57 ` 2.6.9-rc3-mm2 Ingo Molnar
2004-10-07 0:53 ` 2.6.9-rc3-mm2 Pasi Savolainen
2004-10-04 19:56 ` 2.6.9-rc3-mm2 Christian Borntraeger
2004-10-04 21:39 ` 2.6.9-rc3-mm2 Dominik Karall
2004-10-05 3:12 ` 2.6.9-rc3-mm2 Andrew Rodland
2004-10-05 9:25 ` 2.6.9-rc3-mm2 Dominik Karall
2004-10-05 14:07 ` 2.6.9-rc3-mm2 Dominik Karall
2004-10-05 14:21 ` 2.6.9-rc3-mm2 Con Kolivas
2004-10-15 1:38 ` 2.6.9-rc3-mm2 Rusty Russell
2004-10-15 1:44 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-15 2:05 ` 2.6.9-rc3-mm2 Rusty Russell
2004-10-15 2:09 ` 2.6.9-rc3-mm2 Andrew Morton
2004-10-15 3:07 ` 2.6.9-rc3-mm2 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004214855.GA19748@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=annabellesgarden@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.