From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
Linux Arch list <linux-arch@vger.kernel.org>
Subject: Re: All archs: NO_IRQ definition
Date: Wed, 20 Oct 2004 13:26:59 +1000 [thread overview]
Message-ID: <1098242818.25295.4.camel@gaston> (raw)
In-Reply-To: <1098178059.13633.1071.camel@hades.cambridge.redhat.com>
On Tue, 2004-10-19 at 19:27, David Woodhouse wrote:
> And also for every arch where there isn't an overriding reason for it
> _not_ to be -1. If either zero or -1 works, use -1. We'll get better
> coverage of random driver authors doing 'if (!irq)' that way.
>
> So your question becomes: anyone whose architecture can't cope with
> NO_IRQ being -1, please shout now before we break it.
There is a problem using -1 that I noticed when converting drivers/ide.
The probe_irq_off() thing (that we never implemented on ppc, but I
suppose we'll inherit of it via mingo patches now) is defined as...
returning 0 when no interrupt is found. Some drivers actually rely
on that.
So what should I do ? Fix probe_irq_off() & friends to return NO_IRQ
and fix as many drivers as I can find ?
Ben.
next prev parent reply other threads:[~2004-10-20 3:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 6:57 All archs: NO_IRQ definition Benjamin Herrenschmidt
2004-10-19 9:22 ` Matthew Wilcox
2004-10-19 9:23 ` Russell King
2004-10-19 9:25 ` Matthew Wilcox
2004-10-19 9:27 ` David Woodhouse
2004-10-19 9:32 ` Geert Uytterhoeven
2004-10-20 3:26 ` Benjamin Herrenschmidt [this message]
2004-10-20 7:17 ` David Woodhouse
2004-10-20 8:13 ` Russell King
2004-10-20 8:24 ` Benjamin Herrenschmidt
2004-10-19 11:42 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1098242818.25295.4.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=dwmw2@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.