From: Ralf Baechle <ralf@linux-mips.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux Arch list <linux-arch@vger.kernel.org>
Subject: Re: All archs: NO_IRQ definition
Date: Tue, 19 Oct 2004 13:42:53 +0200 [thread overview]
Message-ID: <20041019114253.GC28236@linux-mips.org> (raw)
In-Reply-To: <1098169077.11400.51.camel@gaston>
On Tue, Oct 19, 2004 at 04:57:57PM +1000, Benjamin Herrenschmidt wrote:
> I need to fix a few wrong cases where driver assume that irq = 0 means
> no interrupt. This is wrong, some arch have pefectly valid IRQ 0. We
> started defining NO_IRQ a while ago for that reason, but it seems lot
> of archs didn't catch up. I plan to collect a patch fixing them all but
> you guys will have to tell me what value to use for NO_IRQ (0 ? -1 ?).
>
> Currently, only ppc64, arm and mips add it, and I know what to do for
> ppc, that leaves me with request for the proper value to use for those
> archs:
I guess your grep must have picked up SGI_VINO_IRQ by accident - MIPS
doesn't define NO_IRQ. 0 is used as a normal interrupt number on MIPS,
so -1 is the prefered value for NO_IRQ.
Ralf
prev parent reply other threads:[~2004-10-19 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 6:57 All archs: NO_IRQ definition Benjamin Herrenschmidt
2004-10-19 9:22 ` Matthew Wilcox
2004-10-19 9:23 ` Russell King
2004-10-19 9:25 ` Matthew Wilcox
2004-10-19 9:27 ` David Woodhouse
2004-10-19 9:32 ` Geert Uytterhoeven
2004-10-20 3:26 ` Benjamin Herrenschmidt
2004-10-20 7:17 ` David Woodhouse
2004-10-20 8:13 ` Russell King
2004-10-20 8:24 ` Benjamin Herrenschmidt
2004-10-19 11:42 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041019114253.GC28236@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.